From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Omar Polo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] test-system-cmds: use sh -c instead of guile -c Date: Mon, 30 Jan 2023 16:44:48 +0100 Message-ID: <3OA53BBFX3LDE.24KEIRPA6607E@venera> References: <2PWE9J0AYIN1N.3GXGS3S39YKS3@venera> <83bkmiaclt.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25999"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mblaze/1.2 Cc: guile-devel@gnu.org To: Eli Zaretskii Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Mon Jan 30 16:45:26 2023 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMWLW-0006Yk-GD for guile-devel@m.gmane-mx.org; Mon, 30 Jan 2023 16:45:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMWL5-0005NK-RI; Mon, 30 Jan 2023 10:44:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMWL3-0005Kd-Jf for guile-devel@gnu.org; Mon, 30 Jan 2023 10:44:57 -0500 Original-Received: from mail.omarpolo.com ([144.91.116.244]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMWL1-0001DN-Gr; Mon, 30 Jan 2023 10:44:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1675093490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:in-reply-to:in-reply-to:references:references; bh=N5PdK4M2u3KtQJjNKh0kpJNuLi6+XeWqoeFVbvAC1Tg=; b=EdAHw8HDSOPAKnwY7rnQJBIQiiq9TPVrpwaqaTvs3yrR97wzlcHJV/b8dU3Y5bAAdPHIjj aPpf0/7BzM1ca5Bsmp/VM36/GpFdeeWwGU2blMGm4DffdpidhjiBAI571cTNYisf/af+QL nrIV4QH2yIyOoGvPWUX9uZ1MNzlSBvk= Original-Received: from localhost (host-82-61-20-176.retail.telecomitalia.it [82.61.20.176]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id ab49513a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 30 Jan 2023 16:44:50 +0100 (CET) Original-Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 2ef7b516; Mon, 30 Jan 2023 16:44:48 +0100 (CET) In-Reply-To: <83bkmiaclt.fsf@gnu.org> Received-SPF: pass client-ip=144.91.116.244; envelope-from=op@omarpolo.com; helo=mail.omarpolo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:21663 Archived-At: On 2023/01/28 17:43:42 +0200, Eli Zaretskii wrote: > > Date: Sat, 28 Jan 2023 11:17:07 +0100 > > From: Omar Polo > > > > I'm not sure this patch is palatable as-is, but I'm adding it to the > > OpenBSD port to have less failures in the regress suite. > > > > The main issue is that "guile" may not be available at test time for > > various reasons. (the install prefix is not in $PATH, the executable > > may be renamed --program-suffix, etc...) > > the intent of the test is to test the just-produced Guile binary, so > if that binary is not on PATH, the test suite should be fixed so that > it is on PATH. my understanding is that it's using the just-produced Guile binary and testing wether `system' and `system*' are able spawn executables and return their exit code. Anyway, I have to apologise, I can't reproduce the issue anymore. It was probably something wrong while I was trying to understand bug#61095[0]. Consider the patch dropped, the test suite correctly sets up the $PATH as the README describe. Sorry for the noise. Omar Polo [0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61095