From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Omar Polo Newsgroups: gmane.lisp.guile.devel Subject: [PATCH] test-system-cmds: use sh -c instead of guile -c Date: Sat, 28 Jan 2023 11:17:07 +0100 Message-ID: <2PWE9J0AYIN1N.3GXGS3S39YKS3@venera> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20468"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mblaze/1.2 To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Sat Jan 28 16:27:31 2023 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLn74-0005A5-BI for guile-devel@m.gmane-mx.org; Sat, 28 Jan 2023 16:27:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLn6Z-0000pU-OU; Sat, 28 Jan 2023 10:26:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLiGp-00023T-Tg for guile-devel@gnu.org; Sat, 28 Jan 2023 05:17:16 -0500 Original-Received: from mail.omarpolo.com ([144.91.116.244]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLiGn-0002Fb-LD for guile-devel@gnu.org; Sat, 28 Jan 2023 05:17:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1674901030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc; bh=V7el1TaY1RUTW1aYhCf6nomnJRcs+73CHqrOlmQkA84=; b=kxjNIP90EInxDUIT21NZcBRtCXMs0r+RrqwyHjJXv5LCnuSnjdnrkidTTaicaGwqCDOKaC 8ndTpCykkueKepgUKUwflYIQYsvEuHW7v5oQdVDqMCMf5QpFLRdTewBvI7IEph9yrhLwsE mFjDOayimcSjvj3hRexlQxQTpCD0UfQ= Original-Received: from localhost (host-82-61-20-176.retail.telecomitalia.it [82.61.20.176]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id 20b8feac (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sat, 28 Jan 2023 11:17:10 +0100 (CET) Original-Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id d0f04544 for ; Sat, 28 Jan 2023 11:17:07 +0100 (CET) Received-SPF: pass client-ip=144.91.116.244; envelope-from=op@omarpolo.com; helo=mail.omarpolo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 28 Jan 2023 10:26:58 -0500 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:21651 Archived-At: Hello, I'm not sure this patch is palatable as-is, but I'm adding it to the OpenBSD port to have less failures in the regress suite. The main issue is that "guile" may not be available at test time for various reasons. (the install prefix is not in $PATH, the executable may be renamed --program-suffix, etc...) The comment about windows however makes me think that neither sh may be available. Using meta/guile then is better, other tests are doing that, but I haven't found the right incantation to do so. Thanks, Omar Polo >From 177f7dfa68ff47d448c7a8ac0cb4834eefef8dce Mon Sep 17 00:00:00 2001 From: Omar Polo Date: Sat, 28 Jan 2023 09:58:35 +0000 Subject: [PATCH] test-system-cmds: use sh -c instead of guile -c --- test-suite/standalone/test-system-cmds | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test-suite/standalone/test-system-cmds b/test-suite/standalone/test-system-cmds index 8c590835d..098808201 100755 --- a/test-suite/standalone/test-system-cmds +++ b/test-suite/standalone/test-system-cmds @@ -12,7 +12,7 @@ exec guile -q -s "$0" "$@" ;; Note: Use double quotes since simple quotes are not supported by ;; `cmd.exe' on Windows. - (let ((rs (status:exit-val (system "guile -c \"(exit 42)\"")))) + (let ((rs (status:exit-val (system "sh -c \"exit 42\"")))) (if (not (= 42 rs)) (begin (simple-format @@ -22,7 +22,7 @@ exec guile -q -s "$0" "$@" (exit 1))))) (define (test-system*-cmd) - (let ((rs (status:exit-val (system* "guile" "-c" "(exit 42)")))) + (let ((rs (status:exit-val (system* "sh" "-c" "exit 42")))) (if (not (= 42 rs)) (begin (simple-format -- 2.39.0