From: Mike Gran <spk121@yahoo.com>
To: Rob Browning <rlb@defaultvalue.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp
Date: Wed, 30 Dec 2020 00:41:22 -0800 [thread overview]
Message-ID: <20201230084122.GA824833@spikycactus.com> (raw)
In-Reply-To: <20201230015005.335417-1-rlb@defaultvalue.org>
On Tue, Dec 29, 2020 at 07:50:05PM -0600, Rob Browning wrote:
> * doc/ref/posix.texi: Document mkdtemp! and scm_mkdtemp.
> * libguile/filesys.c: (mkdtemp!, scm_mkdtemp): New functions.
>
> Signed-off-by: Rob Browning <rlb@defaultvalue.org>
Hi Rob,
Since mkdtemp already returns a string of the new directory name,
it might be more scheme-like to not modify the input string, and instead
just return the new directory name.
Also, I don't know how universal mkdtemp is. It does exist in Linux and
OpenBSD, but, I'm not sure about all platforms. So a configure check
might not be amiss.
I'll send a reworked patch for you to consider.
Regards,
Mike Gran
next prev parent reply other threads:[~2020-12-30 8:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 1:50 [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp Rob Browning
2020-12-30 8:41 ` Mike Gran [this message]
2020-12-30 23:05 ` Rob Browning
2021-01-05 0:42 ` Rob Browning
2021-01-11 14:04 ` Mike Gran
2021-01-13 0:34 ` Rob Browning
2021-01-19 14:04 ` Mike Gran
2020-12-30 8:45 ` [PATCH] New procedure mkdtemp to create unique directory names Mike Gran via Developers list for Guile, the GNU extensibility library
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201230084122.GA824833@spikycactus.com \
--to=spk121@yahoo.com \
--cc=guile-devel@gnu.org \
--cc=rlb@defaultvalue.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).