From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Gran Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp Date: Wed, 30 Dec 2020 00:41:22 -0800 Message-ID: <20201230084122.GA824833@spikycactus.com> References: <20201230015005.335417-1-rlb@defaultvalue.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36434"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guile-devel@gnu.org To: Rob Browning Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Wed Dec 30 09:41:52 2020 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuX3I-0009Nv-0A for guile-devel@m.gmane-mx.org; Wed, 30 Dec 2020 09:41:52 +0100 Original-Received: from localhost ([::1]:46670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuX3G-0001bA-O7 for guile-devel@m.gmane-mx.org; Wed, 30 Dec 2020 03:41:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuX35-0001ax-9D for guile-devel@gnu.org; Wed, 30 Dec 2020 03:41:39 -0500 Original-Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:38954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuX32-0003G1-Rq for guile-devel@gnu.org; Wed, 30 Dec 2020 03:41:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1609317691; bh=+KjwGkv+5iiYBdKRb9f7Dj9z+q8MOB+WExLVzFLnRpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=M1t/GYCLkopWHy1aAoy1Flp9XXszt1btt4A6dEwVYXNJLK57QCYfB62n3P4gybu5UiwG12BNByhhmctgkOp35xVq1SNTTSW+6RwhiOKVgtIsfVpc5wd0aw8iyaX9pCpiLRvePu+bXvO/mlnrYABPSqDvojNBsZEdOwdF8oXvUfhORAkvkf63ZQKRpWCrwlQb1Wz8XTVCKWQkDB+CU8RMFyQJ2FWtSLE8uaZxnk7IKxqteWT3nWo0RcniPorsIsGxeY5AeNnMCv/6S6hb0YQxppd8JCUTq9MkQbqtK5Ur044MbZty43wiodyHevkOZNvOYzxB3sDqUoreXqx54qMktA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1609317691; bh=Sel4v9PnKKrhX3MZUw85MkHLqz72n3b/uhLyA6UIwu3=; h=Date:From:To:Subject:From:Subject; b=Ms1tXHQVYS7VGw3N0EATPzPFcbDTVN+VH2HaSLf3MsV5A4Se1XdFPtahI2v44tYf0OmaTKhUqYJ4st5zKGBBCd7VmMr+3hqEJnLferwV5ndlxCudXcfZSx4bP5NIjYyPaT6S+LJYb9IDVRXGzeP2hRbJ7INfAU2mtN4ifTuqkzIPPqHLUgHne6nAJQigOeu0oUHMpoYpSfxiFqv6yeWCbl9H+Rc7/F0OVV5zgBu+qYhue7RvO5RylrfC05+7XMAW7reueoQKJ0FBki8wPkaRzR8sbrwadVRdf1oU7cano2TylXb1bX2y4MCL4aupgmd9DS5WOlZ3SjN+FeZP8aph7Q== X-YMail-OSG: gusrPaoVM1l7q7cmXpA4xgxN_WQo6qFDGzRoE01V6eJYXej9J3Vw3NsMoQELpOg NoRlGe6li61UtJR3uIyopKtOoW985p_re_i8zpjelvoUCbf07u8sp3H8oR8xKLB_A2CQR3pmHw_Y JAJMZzqe5cc9iDbSmeNregRChuF1OfomZlECA5Kls_NYQP8ywtFa2y4Li5NniruI8fjTFgqrmwCB VunfDxOBNoD_pyq615QHKzcM86mJKgnkv9pHXGtG41uconZPi.nXTDmJR62ZN3m6cD1uYV0gQPuO jDdqa2db6IeKL1wi80MUlXWK9FdB2osn75ZUEL5aXHZIEqEsxAOhaekk_FLBt6srzq5GbcOzm5oj btJXJ7An.HR_ESZOuPKYDD8Hgbj8UcSzXJn00sw14p6MtVtRFHrB_L9qaefbRrFhVkHFbnXC7c.W WQq4GOxR2j8tEsaQORRMnxeIwj7NCw2_RAlkrjAPb3bQ91aji1c6_S26s4rV7mgi65DUSgqWFB1l 1TEbz0xShXA4.nvS2V1yS5akUK.OKPrDmMzCLVmnYOBDFcUKn4T.45DkmPTkAnjVKdFMhmH46G6p c7919iMPWzl9z5PYSe.LcZMeEzxsfNTzKFd_mF6rBYt.21_uBEatjufXntMGl4_JwB5v6gY9XVYt VnkQvbfCG.JlOOvn6wrNJ111PneuEWvWfShKawwMuc7uD1j4Bf9gHb6zIuxhWvc9tpMlNDIxr.p. uRHCdj6Mmii.RX5ZVexPHmbRR_G2oPGAPfD9UnMyEf_uMw7ktb2kNko0NwriBMiyZ5HEN4zm70xr vBTAEoWFRCs9pXt6TvYFTcBGvQf8GRqXvc687SnZxC Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Wed, 30 Dec 2020 08:41:31 +0000 Original-Received: by smtp420.mail.ne1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID e197456da35e3408d13757a9a5a1793b; Wed, 30 Dec 2020 08:41:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20201230015005.335417-1-rlb@defaultvalue.org> X-Mailer: WebService/1.1.17278 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=66.163.185.33; envelope-from=spk121@yahoo.com; helo=sonic313-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20626 Archived-At: On Tue, Dec 29, 2020 at 07:50:05PM -0600, Rob Browning wrote: > * doc/ref/posix.texi: Document mkdtemp! and scm_mkdtemp. > * libguile/filesys.c: (mkdtemp!, scm_mkdtemp): New functions. > > Signed-off-by: Rob Browning Hi Rob, Since mkdtemp already returns a string of the new directory name, it might be more scheme-like to not modify the input string, and instead just return the new directory name. Also, I don't know how universal mkdtemp is. It does exist in Linux and OpenBSD, but, I'm not sure about all platforms. So a configure check might not be amiss. I'll send a reworked patch for you to consider. Regards, Mike Gran