unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Mike Gran <spk121@yahoo.com>
To: Rob Browning <rlb@defaultvalue.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp
Date: Mon, 11 Jan 2021 06:04:14 -0800	[thread overview]
Message-ID: <20210111140353.GA1546612@spikycactus.com> (raw)
In-Reply-To: <875z4ctdsw.fsf@trouble.defaultvalue.org>

On Mon, Jan 04, 2021 at 06:42:07PM -0600, Rob Browning wrote:
> Rob Browning <rlb@defaultvalue.org> writes:
> 
> > Mike Gran <spk121@yahoo.com> writes:
> >
> >> Since mkdtemp already returns a string of the new directory name,
> >> it might be more scheme-like to not modify the input string, and instead
> >> just return the new directory name.
> >
> > Perhaps, though I was just matching the existing semantics of guile
> > mkstemp, i.e. figured maybe they should behave the same.
> 
> ...mkstemp! I meant, and I think I might still somewhat favor keeping
> the correspondence between a mkstemp! and mkdtemp! that have the same
> semantics, and more or less directly match their POSIX functions.

OK, fair enough. I'll push a patch on mkdtemp! in a day or two if
you're good with the idea.  (I asked on IRC.) But, one thing I'd like
to change, if you don't mind, is the split into scm_i_mkdtemp and
scm_mkdtemp because there is no internal client of scm_i_mkdtemp.

Regards,
Mike Gran




  reply	other threads:[~2021-01-11 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30  1:50 [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp Rob Browning
2020-12-30  8:41 ` Mike Gran
2020-12-30 23:05   ` Rob Browning
2021-01-05  0:42     ` Rob Browning
2021-01-11 14:04       ` Mike Gran [this message]
2021-01-13  0:34         ` Rob Browning
2021-01-19 14:04           ` Mike Gran
2020-12-30  8:45 ` [PATCH] New procedure mkdtemp to create unique directory names Mike Gran via Developers list for Guile, the GNU extensibility library

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111140353.GA1546612@spikycactus.com \
    --to=spk121@yahoo.com \
    --cc=guile-devel@gnu.org \
    --cc=rlb@defaultvalue.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).