guile-clutter: fixing ClutterMargin special wrapper

guile-clutter: fixing ClutterMargin special wrapper

[David Pirotte]

[-- Attachment #1: Type: text/plain, Size: 80 bytes --]

Hello,

Please review and let me know, if it's ok, I'll push it.

Thanks,
David

[-- Attachment #2: 0001-fixing-ClutterMargin-special-wrapper.patch --]
[-- Type: text/x-patch, Size: 1196 bytes --]

From a8166f67bd752ff7c71af50b27cfc52b2de4fe37 Mon Sep 17 00:00:00 2001
From: David PIROTTE <david@altosw.be>
Date: Fri, 18 Apr 2014 16:24:43 -0300
Subject: [PATCH] fixing ClutterMargin special wrapper

* clutter/gnome/gw/clutter-support.c: scm_scm_to_clutter_margin to use
  scm_to_double (instead of scm_to_uint8) for all 4 ClutterMargin structure
  elements.
---
 clutter/gnome/gw/clutter-support.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/clutter/gnome/gw/clutter-support.c b/clutter/gnome/gw/clutter-support.c
index 7650f9e..e895d1e 100644
--- a/clutter/gnome/gw/clutter-support.c
+++ b/clutter/gnome/gw/clutter-support.c
@@ -147,10 +147,10 @@ scm_scm_to_clutter_margin (SCM scm)
 {
     ClutterMargin ret;
     
-    ret.left = scm_to_uint8 (scm_car (scm));
-    ret.right = scm_to_uint8 (scm_cadr (scm));
-    ret.top = scm_to_uint8 (scm_caddr (scm));
-    ret.bottom = scm_to_uint8 (scm_cadddr (scm));
+    ret.left = scm_to_double (scm_car (scm));
+    ret.right = scm_to_double (scm_cadr (scm));
+    ret.top = scm_to_double (scm_caddr (scm));
+    ret.bottom = scm_to_double (scm_cadddr (scm));
 
     return clutter_margin_copy (&ret);
 }
-- 
1.9.1

Re: guile-clutter: fixing ClutterMargin special wrapper

[Mark H Weaver]

Hi David,

David Pirotte <david@altosw.be> writes:
> From a8166f67bd752ff7c71af50b27cfc52b2de4fe37 Mon Sep 17 00:00:00 2001
> From: David PIROTTE <david@altosw.be>
> Date: Fri, 18 Apr 2014 16:24:43 -0300
> Subject: [PATCH] fixing ClutterMargin special wrapper

Rather:
scm_scm_to_clutter_margin: Use scm_to_double, not scm_to_uint8.

> * clutter/gnome/gw/clutter-support.c: scm_scm_to_clutter_margin to use

Rather:
* clutter/gnome/gw/clutter-support.c (scm_scm_to_clutter_margin): Use

>   scm_to_double (instead of scm_to_uint8) for all 4 ClutterMargin structure
>   elements.

Other than that, looks good to me.  Please push!

    Thanks,
      Mark


> ---
>  clutter/gnome/gw/clutter-support.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/clutter/gnome/gw/clutter-support.c b/clutter/gnome/gw/clutter-support.c
> index 7650f9e..e895d1e 100644
> --- a/clutter/gnome/gw/clutter-support.c
> +++ b/clutter/gnome/gw/clutter-support.c
> @@ -147,10 +147,10 @@ scm_scm_to_clutter_margin (SCM scm)
>  {
>      ClutterMargin ret;
>      
> -    ret.left = scm_to_uint8 (scm_car (scm));
> -    ret.right = scm_to_uint8 (scm_cadr (scm));
> -    ret.top = scm_to_uint8 (scm_caddr (scm));
> -    ret.bottom = scm_to_uint8 (scm_cadddr (scm));
> +    ret.left = scm_to_double (scm_car (scm));
> +    ret.right = scm_to_double (scm_cadr (scm));
> +    ret.top = scm_to_double (scm_caddr (scm));
> +    ret.bottom = scm_to_double (scm_cadddr (scm));
>  
>      return clutter_margin_copy (&ret);
>  }

Re: guile-clutter: fixing ClutterMargin special wrapper

[David Pirotte]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

Hi Mark,

> Rather:
> scm_scm_to_clutter_margin: Use scm_to_double, not scm_to_uint8.
> 
> > * clutter/gnome/gw/clutter-support.c: scm_scm_to_clutter_margin to use
> 
> Rather:
> * clutter/gnome/gw/clutter-support.c (scm_scm_to_clutter_margin): Use

Thank you, I have changed the commit message as suggested and pushed.

Cheers,
David

[-- Attachment #2: 0001-fixing-ClutterMargin-special-wrapper.patch --]
[-- Type: text/x-patch, Size: 1186 bytes --]

From 28436efe5ba1472dcc199d87a6b07b993bb3c441 Mon Sep 17 00:00:00 2001
From: David PIROTTE <david@altosw.be>
Date: Fri, 18 Apr 2014 23:02:09 -0300
Subject: [PATCH] fixing ClutterMargin special wrapper

* clutter/gnome/gw/clutter-support.c (scm_scm_to_clutter_margin): Use
  scm_to_double, not scm_to_uint8, for all 4 ClutterMargin structure elements.
---
 clutter/gnome/gw/clutter-support.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/clutter/gnome/gw/clutter-support.c b/clutter/gnome/gw/clutter-support.c
index 7650f9e..e895d1e 100644
--- a/clutter/gnome/gw/clutter-support.c
+++ b/clutter/gnome/gw/clutter-support.c
@@ -147,10 +147,10 @@ scm_scm_to_clutter_margin (SCM scm)
 {
     ClutterMargin ret;
     
-    ret.left = scm_to_uint8 (scm_car (scm));
-    ret.right = scm_to_uint8 (scm_cadr (scm));
-    ret.top = scm_to_uint8 (scm_caddr (scm));
-    ret.bottom = scm_to_uint8 (scm_cadddr (scm));
+    ret.left = scm_to_double (scm_car (scm));
+    ret.right = scm_to_double (scm_cadr (scm));
+    ret.top = scm_to_double (scm_caddr (scm));
+    ret.bottom = scm_to_double (scm_cadddr (scm));
 
     return clutter_margin_copy (&ret);
 }
-- 
1.9.1