From: Mark H Weaver <mhw@netris.org>
To: David Pirotte <david@altosw.be>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: guile-clutter: fixing ClutterMargin special wrapper
Date: Fri, 18 Apr 2014 18:34:40 -0400 [thread overview]
Message-ID: <87r44u467z.fsf@yeeloong.lan> (raw)
In-Reply-To: <20140418165148.227d2c71@capac> (David Pirotte's message of "Fri, 18 Apr 2014 16:51:48 -0300")
Hi David,
David Pirotte <david@altosw.be> writes:
> From a8166f67bd752ff7c71af50b27cfc52b2de4fe37 Mon Sep 17 00:00:00 2001
> From: David PIROTTE <david@altosw.be>
> Date: Fri, 18 Apr 2014 16:24:43 -0300
> Subject: [PATCH] fixing ClutterMargin special wrapper
Rather:
scm_scm_to_clutter_margin: Use scm_to_double, not scm_to_uint8.
> * clutter/gnome/gw/clutter-support.c: scm_scm_to_clutter_margin to use
Rather:
* clutter/gnome/gw/clutter-support.c (scm_scm_to_clutter_margin): Use
> scm_to_double (instead of scm_to_uint8) for all 4 ClutterMargin structure
> elements.
Other than that, looks good to me. Please push!
Thanks,
Mark
> ---
> clutter/gnome/gw/clutter-support.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/clutter/gnome/gw/clutter-support.c b/clutter/gnome/gw/clutter-support.c
> index 7650f9e..e895d1e 100644
> --- a/clutter/gnome/gw/clutter-support.c
> +++ b/clutter/gnome/gw/clutter-support.c
> @@ -147,10 +147,10 @@ scm_scm_to_clutter_margin (SCM scm)
> {
> ClutterMargin ret;
>
> - ret.left = scm_to_uint8 (scm_car (scm));
> - ret.right = scm_to_uint8 (scm_cadr (scm));
> - ret.top = scm_to_uint8 (scm_caddr (scm));
> - ret.bottom = scm_to_uint8 (scm_cadddr (scm));
> + ret.left = scm_to_double (scm_car (scm));
> + ret.right = scm_to_double (scm_cadr (scm));
> + ret.top = scm_to_double (scm_caddr (scm));
> + ret.bottom = scm_to_double (scm_cadddr (scm));
>
> return clutter_margin_copy (&ret);
> }
next prev parent reply other threads:[~2014-04-18 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 19:51 guile-clutter: fixing ClutterMargin special wrapper David Pirotte
2014-04-18 22:34 ` Mark H Weaver [this message]
2014-04-19 2:10 ` David Pirotte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r44u467z.fsf@yeeloong.lan \
--to=mhw@netris.org \
--cc=david@altosw.be \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).