From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.devel Subject: Re: guile-clutter: fixing ClutterMargin special wrapper Date: Fri, 18 Apr 2014 18:34:40 -0400 Message-ID: <87r44u467z.fsf@yeeloong.lan> References: <20140418165148.227d2c71@capac> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1397860604 12652 80.91.229.3 (18 Apr 2014 22:36:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Apr 2014 22:36:44 +0000 (UTC) Cc: guile-devel To: David Pirotte Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Apr 19 00:36:37 2014 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WbHOe-00084D-2X for guile-devel@m.gmane.org; Sat, 19 Apr 2014 00:36:36 +0200 Original-Received: from localhost ([::1]:40231 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WbHOd-0002i9-NE for guile-devel@m.gmane.org; Fri, 18 Apr 2014 18:36:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WbHOW-0002Wh-Bl for guile-devel@gnu.org; Fri, 18 Apr 2014 18:36:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WbHOQ-0001ji-Fd for guile-devel@gnu.org; Fri, 18 Apr 2014 18:36:28 -0400 Original-Received: from world.peace.net ([96.39.62.75]:57329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WbHOQ-0001jc-BX for guile-devel@gnu.org; Fri, 18 Apr 2014 18:36:22 -0400 Original-Received: from turntable.mit.edu ([18.160.0.29] helo=yeeloong.lan) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WbHOJ-0004IR-8H; Fri, 18 Apr 2014 18:36:15 -0400 In-Reply-To: <20140418165148.227d2c71@capac> (David Pirotte's message of "Fri, 18 Apr 2014 16:51:48 -0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 96.39.62.75 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:17082 Archived-At: Hi David, David Pirotte writes: > From a8166f67bd752ff7c71af50b27cfc52b2de4fe37 Mon Sep 17 00:00:00 2001 > From: David PIROTTE > Date: Fri, 18 Apr 2014 16:24:43 -0300 > Subject: [PATCH] fixing ClutterMargin special wrapper Rather: scm_scm_to_clutter_margin: Use scm_to_double, not scm_to_uint8. > * clutter/gnome/gw/clutter-support.c: scm_scm_to_clutter_margin to use Rather: * clutter/gnome/gw/clutter-support.c (scm_scm_to_clutter_margin): Use > scm_to_double (instead of scm_to_uint8) for all 4 ClutterMargin structure > elements. Other than that, looks good to me. Please push! Thanks, Mark > --- > clutter/gnome/gw/clutter-support.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/clutter/gnome/gw/clutter-support.c b/clutter/gnome/gw/clutter-support.c > index 7650f9e..e895d1e 100644 > --- a/clutter/gnome/gw/clutter-support.c > +++ b/clutter/gnome/gw/clutter-support.c > @@ -147,10 +147,10 @@ scm_scm_to_clutter_margin (SCM scm) > { > ClutterMargin ret; > > - ret.left = scm_to_uint8 (scm_car (scm)); > - ret.right = scm_to_uint8 (scm_cadr (scm)); > - ret.top = scm_to_uint8 (scm_caddr (scm)); > - ret.bottom = scm_to_uint8 (scm_cadddr (scm)); > + ret.left = scm_to_double (scm_car (scm)); > + ret.right = scm_to_double (scm_cadr (scm)); > + ret.top = scm_to_double (scm_caddr (scm)); > + ret.bottom = scm_to_double (scm_cadddr (scm)); > > return clutter_margin_copy (&ret); > }