From: Daniel Hartwig <mandyke@gmail.com>
To: 13741@debbugs.gnu.org
Subject: bug#13741: [PATCH] test-suite: eq-ness of numbers, characters is unspecified
Date: Tue, 19 Feb 2013 12:29:23 +0800 [thread overview]
Message-ID: <CAN3veRdvoSpTc=t2EkK2jeR1ex=VHV4c6+_k0RLGW4f0FfBTaA@mail.gmail.com> (raw)
In-Reply-To: <1361238914-14823-1-git-send-email-mandyke@gmail.com>
On 19 February 2013 09:55, Daniel Hartwig <mandyke@gmail.com> wrote:
> * test-suite/tests/00-socket.test:
> * test-suite/tests/alist.test:
> * test-suite/tests/elisp.test:
> * test-suite/tests/encoding-iso88591.test:
> * test-suite/tests/encoding-iso88597.test:
> * test-suite/tests/encoding-utf8.test:
> * test-suite/tests/hash.test:
> * test-suite/tests/i18n.test:
> * test-suite/tests/modules.test:
> * test-suite/tests/ports.test:
> * test-suite/tests/srfi-35.test: Make tests use eqv? instead of eq? when
> comparing numbers, characters. Checked also for similar uses of
> assq[-ref].
>
> * test-suite/tests/vlist.test ("vhash-delete honors HASH"): Change test
> to use eqv-ness, not eq-ness, which should not impact its purpose as
> these two are equivalent for strings.
Located using grep and inspecting each occurance of eq?, assq, consq.
The tests weren't necessarily failing, just incorrect for their
reliance on unspecified results. Most checks involving numbers were
already using eqv?, equal?, or =.
The following were spotted but have been left alone for now:
* list.test (diff-unrolled): Uses eq? internally, called on lists
with numbers.
* tree-il.test:
* elisp.test ("assq"): Is that correct for Guile's elisp? _(elisp)
Comparison of Numbers_ says that each integer does have a unique
object in Emacs Lisp, and using ‘eq’ is valid though not
recommended.
Regards
next prev parent reply other threads:[~2013-02-19 4:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 3:27 bug#13741: guile-2.0: optimize, and eq-ness of literals (test-suite) Daniel Hartwig
2013-02-18 9:16 ` Ludovic Courtès
2013-02-18 10:02 ` Daniel Hartwig
2013-03-01 16:13 ` Mark H Weaver
2013-02-18 17:19 ` Andy Wingo
2013-02-18 23:48 ` Mark H Weaver
2013-02-19 1:55 ` bug#13741: [PATCH] test-suite: eq-ness of numbers, characters is unspecified Daniel Hartwig
2013-02-19 4:29 ` Daniel Hartwig [this message]
2013-02-19 5:19 ` Mark H Weaver
2013-03-01 16:10 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN3veRdvoSpTc=t2EkK2jeR1ex=VHV4c6+_k0RLGW4f0FfBTaA@mail.gmail.com' \
--to=mandyke@gmail.com \
--cc=13741@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).