From: Mark H Weaver <mhw@netris.org>
To: Daniel Hartwig <mandyke@gmail.com>
Cc: 13741@debbugs.gnu.org
Subject: bug#13741: [PATCH] test-suite: eq-ness of numbers, characters is unspecified
Date: Fri, 01 Mar 2013 11:10:03 -0500 [thread overview]
Message-ID: <87bob3umn8.fsf@tines.lan> (raw)
In-Reply-To: <87bobgop7z.fsf@tines.lan> (Mark H. Weaver's message of "Tue, 19 Feb 2013 00:19:12 -0500")
I wrote:
> Daniel Hartwig <mandyke@gmail.com> writes:
>> * test-suite/tests/00-socket.test:
>> * test-suite/tests/alist.test:
>> * test-suite/tests/elisp.test:
>> * test-suite/tests/encoding-iso88591.test:
>> * test-suite/tests/encoding-iso88597.test:
>> * test-suite/tests/encoding-utf8.test:
>> * test-suite/tests/hash.test:
>> * test-suite/tests/i18n.test:
>> * test-suite/tests/modules.test:
>> * test-suite/tests/ports.test:
>> * test-suite/tests/srfi-35.test: Make tests use eqv? instead of eq? when
>> comparing numbers, characters. Checked also for similar uses of
>> assq[-ref].
>>
>> * test-suite/tests/vlist.test ("vhash-delete honors HASH"): Change test
>> to use eqv-ness, not eq-ness, which should not impact its purpose as
>> these two are equivalent for strings.
>
> I think we should apply this patch. Although we can currently rely on
> 'eq?' working properly for fixnums and characters in Guile, misuse of
> 'eq?' is widespread, and our misuse of it in our own code contributes to
> the confusion. IMO we should set a better example.
>
> What do other people think?
Having heard no objections over 10 days, I went ahead and pushed this.
Thanks!
Mark
prev parent reply other threads:[~2013-03-01 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 3:27 bug#13741: guile-2.0: optimize, and eq-ness of literals (test-suite) Daniel Hartwig
2013-02-18 9:16 ` Ludovic Courtès
2013-02-18 10:02 ` Daniel Hartwig
2013-03-01 16:13 ` Mark H Weaver
2013-02-18 17:19 ` Andy Wingo
2013-02-18 23:48 ` Mark H Weaver
2013-02-19 1:55 ` bug#13741: [PATCH] test-suite: eq-ness of numbers, characters is unspecified Daniel Hartwig
2013-02-19 4:29 ` Daniel Hartwig
2013-02-19 5:19 ` Mark H Weaver
2013-03-01 16:10 ` Mark H Weaver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bob3umn8.fsf@tines.lan \
--to=mhw@netris.org \
--cc=13741@debbugs.gnu.org \
--cc=mandyke@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).