From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Hartwig Newsgroups: gmane.lisp.guile.bugs Subject: bug#13741: [PATCH] test-suite: eq-ness of numbers, characters is unspecified Date: Tue, 19 Feb 2013 12:29:23 +0800 Message-ID: References: <87ip5pnpyd.fsf@tines.lan> <1361238914-14823-1-git-send-email-mandyke@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1361248212 10785 80.91.229.3 (19 Feb 2013 04:30:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Feb 2013 04:30:12 +0000 (UTC) To: 13741@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Feb 19 05:30:34 2013 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U7eqY-0007iJ-RY for guile-bugs@m.gmane.org; Tue, 19 Feb 2013 05:30:27 +0100 Original-Received: from localhost ([::1]:53196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7eqE-0007aC-BS for guile-bugs@m.gmane.org; Mon, 18 Feb 2013 23:30:06 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7eqA-0007YV-Ca for bug-guile@gnu.org; Mon, 18 Feb 2013 23:30:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7eq7-0004wu-5d for bug-guile@gnu.org; Mon, 18 Feb 2013 23:30:01 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7eq7-0004wn-0l for bug-guile@gnu.org; Mon, 18 Feb 2013 23:29:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U7er7-00054w-Vh for bug-guile@gnu.org; Mon, 18 Feb 2013 23:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Hartwig Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 19 Feb 2013 04:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13741 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 13741-submit@debbugs.gnu.org id=B13741.136124823119486 (code B ref 13741); Tue, 19 Feb 2013 04:31:01 +0000 Original-Received: (at 13741) by debbugs.gnu.org; 19 Feb 2013 04:30:31 +0000 Original-Received: from localhost ([127.0.0.1]:35693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7eqc-00054F-1v for submit@debbugs.gnu.org; Mon, 18 Feb 2013 23:30:31 -0500 Original-Received: from mail-ia0-f175.google.com ([209.85.210.175]:64216) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7eqZ-000547-Sp for 13741@debbugs.gnu.org; Mon, 18 Feb 2013 23:30:28 -0500 Original-Received: by mail-ia0-f175.google.com with SMTP id r4so5640977iaj.6 for <13741@debbugs.gnu.org>; Mon, 18 Feb 2013 20:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type:content-transfer-encoding; bh=c09RCQkQlCzuyrRmQ2/MeZ29fuF8P0toKy0Nr+yCjSU=; b=FTT8+yCYrT2ZOONFTavHKgiSTqBhqwwJMQpB2coT4yeLvw3DODU0la/IFEmkQ4SRD4 cFRXrbpRdoOWfbkP1jx/6FK5KwyYkTftNttFq0Evg+yQvkTBsIUFDcPDyMQYdum64x6n PNX5nqSBJSeYta0nlb3YLXEMNfZ6XJGiq00CoDKLJ3YW+tbiCBlB/Ha0NUx2exKBROL8 jQQfLb6ng5DW3hLRxDaYN2jzdn8ACXVrwAIH97HwPGRMWC0nzz9LqWldSg9J9xU4uBQy /Rbqt+l/XqCRMpTn8UExnAxafBnr3NrRx1eyFM6yxkdEU4PH8QKyv/Ceyh1sqUax2RbO emRw== X-Received: by 10.50.187.225 with SMTP id fv1mr8596069igc.96.1361248163886; Mon, 18 Feb 2013 20:29:23 -0800 (PST) Original-Received: by 10.64.76.51 with HTTP; Mon, 18 Feb 2013 20:29:23 -0800 (PST) In-Reply-To: <1361238914-14823-1-git-send-email-mandyke@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:6750 Archived-At: On 19 February 2013 09:55, Daniel Hartwig wrote: > * test-suite/tests/00-socket.test: > * test-suite/tests/alist.test: > * test-suite/tests/elisp.test: > * test-suite/tests/encoding-iso88591.test: > * test-suite/tests/encoding-iso88597.test: > * test-suite/tests/encoding-utf8.test: > * test-suite/tests/hash.test: > * test-suite/tests/i18n.test: > * test-suite/tests/modules.test: > * test-suite/tests/ports.test: > * test-suite/tests/srfi-35.test: Make tests use eqv? instead of eq? when > comparing numbers, characters. Checked also for similar uses of > assq[-ref]. > > * test-suite/tests/vlist.test ("vhash-delete honors HASH"): Change test > to use eqv-ness, not eq-ness, which should not impact its purpose as > these two are equivalent for strings. Located using grep and inspecting each occurance of eq?, assq, consq. The tests weren't necessarily failing, just incorrect for their reliance on unspecified results. Most checks involving numbers were already using eqv?, equal?, or =3D. The following were spotted but have been left alone for now: * list.test (diff-unrolled): Uses eq? internally, called on lists with numbers. * tree-il.test: * elisp.test ("assq"): Is that correct for Guile's elisp? _(elisp) Comparison of Numbers_ says that each integer does have a unique object in Emacs Lisp, and using =E2=80=98eq=E2=80=99 is valid though not recommended. Regards