bug#19172: [PATCH 1/1] Remove unused funcs that cause a building error

bug#19172: [PATCH 1/1] Remove unused funcs that cause a building error

[Pedro Aguilar]

Remove unused static inline functions str_upcase_l() and
str_downcase_l() that cause the compilation error
'dereferencing pointer to incomplete type' when building
for ARM using a buildroot-generated toolchain.

Signed-off-by: Pedro Aguilar <paguilar@paguilar.org>
---
 libguile/i18n.c | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/libguile/i18n.c b/libguile/i18n.c
index c6b9b84..32278bd 100644
--- a/libguile/i18n.c
+++ b/libguile/i18n.c
@@ -851,26 +851,6 @@ str_downcase (register char *dst, register const char *src)
   *dst = '\0';
 }
 
-#ifdef USE_GNU_LOCALE_API
-static inline void
-str_upcase_l (register char *dst, register const char *src,
-	      scm_t_locale locale)
-{
-  for (; *src != '\0'; src++, dst++)
-    *dst = toupper_l (*src, locale);
-  *dst = '\0';
-}
-
-static inline void
-str_downcase_l (register char *dst, register const char *src,
-		scm_t_locale locale)
-{
-  for (; *src != '\0'; src++, dst++)
-    *dst = tolower_l (*src, locale);
-  *dst = '\0';
-}
-#endif
-
 
 SCM_DEFINE (scm_string_locale_lt, "string-locale<?", 2, 1, 0,
 	    (SCM s1, SCM s2, SCM locale),
-- 
1.9.1

bug#19172: [PATCH 1/1] Remove unused funcs that cause a building error

[Andy Wingo]

Thanks for the patch!  I applied a version that also deleted the
previous two static inline helpers.  Weird to have them around.  Will be
in 2.0.12 and 2.1.4.

Cheers,

Andy

On Tue 25 Nov 2014 00:14, Pedro Aguilar <paguilar@paguilar.org> writes:

> Remove unused static inline functions str_upcase_l() and
> str_downcase_l() that cause the compilation error
> 'dereferencing pointer to incomplete type' when building
> for ARM using a buildroot-generated toolchain.
>
> Signed-off-by: Pedro Aguilar <paguilar@paguilar.org>
> ---
>  libguile/i18n.c | 20 --------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/libguile/i18n.c b/libguile/i18n.c
> index c6b9b84..32278bd 100644
> --- a/libguile/i18n.c
> +++ b/libguile/i18n.c
> @@ -851,26 +851,6 @@ str_downcase (register char *dst, register const char *src)
>    *dst = '\0';
>  }
>  
> -#ifdef USE_GNU_LOCALE_API
> -static inline void
> -str_upcase_l (register char *dst, register const char *src,
> -	      scm_t_locale locale)
> -{
> -  for (; *src != '\0'; src++, dst++)
> -    *dst = toupper_l (*src, locale);
> -  *dst = '\0';
> -}
> -
> -static inline void
> -str_downcase_l (register char *dst, register const char *src,
> -		scm_t_locale locale)
> -{
> -  for (; *src != '\0'; src++, dst++)
> -    *dst = tolower_l (*src, locale);
> -  *dst = '\0';
> -}
> -#endif
> -
>  
>  SCM_DEFINE (scm_string_locale_lt, "string-locale<?", 2, 1, 0,
>  	    (SCM s1, SCM s2, SCM locale),