unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Andy Wingo <wingo@pobox.com>
To: Pedro Aguilar <paguilar@paguilar.org>
Cc: thomas.petazzoni@free-electrons.com, 19172-done@debbugs.gnu.org
Subject: bug#19172: [PATCH 1/1] Remove unused funcs that cause a building error
Date: Wed, 22 Jun 2016 16:49:01 +0200	[thread overview]
Message-ID: <87y45xs2hu.fsf@pobox.com> (raw)
In-Reply-To: <1416870872-13385-1-git-send-email-paguilar@paguilar.org> (Pedro Aguilar's message of "Tue, 25 Nov 2014 00:14:32 +0100")

Thanks for the patch!  I applied a version that also deleted the
previous two static inline helpers.  Weird to have them around.  Will be
in 2.0.12 and 2.1.4.

Cheers,

Andy

On Tue 25 Nov 2014 00:14, Pedro Aguilar <paguilar@paguilar.org> writes:

> Remove unused static inline functions str_upcase_l() and
> str_downcase_l() that cause the compilation error
> 'dereferencing pointer to incomplete type' when building
> for ARM using a buildroot-generated toolchain.
>
> Signed-off-by: Pedro Aguilar <paguilar@paguilar.org>
> ---
>  libguile/i18n.c | 20 --------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/libguile/i18n.c b/libguile/i18n.c
> index c6b9b84..32278bd 100644
> --- a/libguile/i18n.c
> +++ b/libguile/i18n.c
> @@ -851,26 +851,6 @@ str_downcase (register char *dst, register const char *src)
>    *dst = '\0';
>  }
>  
> -#ifdef USE_GNU_LOCALE_API
> -static inline void
> -str_upcase_l (register char *dst, register const char *src,
> -	      scm_t_locale locale)
> -{
> -  for (; *src != '\0'; src++, dst++)
> -    *dst = toupper_l (*src, locale);
> -  *dst = '\0';
> -}
> -
> -static inline void
> -str_downcase_l (register char *dst, register const char *src,
> -		scm_t_locale locale)
> -{
> -  for (; *src != '\0'; src++, dst++)
> -    *dst = tolower_l (*src, locale);
> -  *dst = '\0';
> -}
> -#endif
> -
>  
>  SCM_DEFINE (scm_string_locale_lt, "string-locale<?", 2, 1, 0,
>  	    (SCM s1, SCM s2, SCM locale),





      reply	other threads:[~2016-06-22 14:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 23:14 bug#19172: [PATCH 1/1] Remove unused funcs that cause a building error Pedro Aguilar
2016-06-22 14:49 ` Andy Wingo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y45xs2hu.fsf@pobox.com \
    --to=wingo@pobox.com \
    --cc=19172-done@debbugs.gnu.org \
    --cc=paguilar@paguilar.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).