From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#19172: [PATCH 1/1] Remove unused funcs that cause a building error Date: Wed, 22 Jun 2016 16:49:01 +0200 Message-ID: <87y45xs2hu.fsf@pobox.com> References: <1416870872-13385-1-git-send-email-paguilar@paguilar.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466607066 31776 80.91.229.3 (22 Jun 2016 14:51:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Jun 2016 14:51:06 +0000 (UTC) Cc: thomas.petazzoni@free-electrons.com, 19172-done@debbugs.gnu.org To: Pedro Aguilar Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Wed Jun 22 16:50:52 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bFjTt-0005Ul-LN for guile-bugs@m.gmane.org; Wed, 22 Jun 2016 16:50:17 +0200 Original-Received: from localhost ([::1]:58886 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFjTs-0003Pb-Ok for guile-bugs@m.gmane.org; Wed, 22 Jun 2016 10:50:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFjTk-0003LU-2d for bug-guile@gnu.org; Wed, 22 Jun 2016 10:50:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFjTf-000311-2O for bug-guile@gnu.org; Wed, 22 Jun 2016 10:50:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFjTe-00030x-Ud for bug-guile@gnu.org; Wed, 22 Jun 2016 10:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bFjTe-0004ai-Ma for bug-guile@gnu.org; Wed, 22 Jun 2016 10:50:02 -0400 Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Wed, 22 Jun 2016 14:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 19172 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Mail-Followup-To: 19172@debbugs.gnu.org, wingo@pobox.com, paguilar@paguilar.org Original-Received: via spool by 19172-done@debbugs.gnu.org id=D19172.146660695217574 (code D ref 19172); Wed, 22 Jun 2016 14:50:02 +0000 Original-Received: (at 19172-done) by debbugs.gnu.org; 22 Jun 2016 14:49:12 +0000 Original-Received: from localhost ([127.0.0.1]:51273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFjSq-0004ZO-JN for submit@debbugs.gnu.org; Wed, 22 Jun 2016 10:49:12 -0400 Original-Received: from pb-sasl2.pobox.com ([64.147.108.67]:61860 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFjSo-0004ZF-8U for 19172-done@debbugs.gnu.org; Wed, 22 Jun 2016 10:49:10 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 7364C1F284; Wed, 22 Jun 2016 10:49:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=kPSeMKQKsWyW+CLV2TjqaAiFTDc=; b=PEBt8c /QG+SSRAsi7ExM1moNZMmMrVkswXiFGntnukLpBtX7m50gC7lm+oznO4Fe+GITtC +F1Xgertg9wwYpVQ55wwDEHaaDWdekyrrkUFjS0X4N5geEY/t/otUo2qHJM9wxce VLbxahRKWJ2QHLNyGJ0vB0T4diU7WnMBwCab4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=Z6oWxEjl4JAMOR08d4SvgjMFSf8uZn02 5M1MCH6lhGmmT9Ef6Mzp2IG5i12eiVVEqojDQhDYDe3EhMXEucoF2SThnowtknHc HgWNubuCvkocLCP1kH1wL8W7BaCGURR7RjDmSE9IT6BlN0WmHg25gIuSjc5kDklV n/9Yys723oU= Original-Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 6BF751F281; Wed, 22 Jun 2016 10:49:09 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id 9633D1F280; Wed, 22 Jun 2016 10:49:08 -0400 (EDT) In-Reply-To: <1416870872-13385-1-git-send-email-paguilar@paguilar.org> (Pedro Aguilar's message of "Tue, 25 Nov 2014 00:14:32 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-Pobox-Relay-ID: 79A51D3E-3888-11E6-B460-28A6F1301B6D-02397024!pb-sasl2.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8126 Archived-At: Thanks for the patch! I applied a version that also deleted the previous two static inline helpers. Weird to have them around. Will be in 2.0.12 and 2.1.4. Cheers, Andy On Tue 25 Nov 2014 00:14, Pedro Aguilar writes: > Remove unused static inline functions str_upcase_l() and > str_downcase_l() that cause the compilation error > 'dereferencing pointer to incomplete type' when building > for ARM using a buildroot-generated toolchain. > > Signed-off-by: Pedro Aguilar > --- > libguile/i18n.c | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/libguile/i18n.c b/libguile/i18n.c > index c6b9b84..32278bd 100644 > --- a/libguile/i18n.c > +++ b/libguile/i18n.c > @@ -851,26 +851,6 @@ str_downcase (register char *dst, register const char *src) > *dst = '\0'; > } > > -#ifdef USE_GNU_LOCALE_API > -static inline void > -str_upcase_l (register char *dst, register const char *src, > - scm_t_locale locale) > -{ > - for (; *src != '\0'; src++, dst++) > - *dst = toupper_l (*src, locale); > - *dst = '\0'; > -} > - > -static inline void > -str_downcase_l (register char *dst, register const char *src, > - scm_t_locale locale) > -{ > - for (; *src != '\0'; src++, dst++) > - *dst = tolower_l (*src, locale); > - *dst = '\0'; > -} > -#endif > - > > SCM_DEFINE (scm_string_locale_lt, "string-locale (SCM s1, SCM s2, SCM locale),