From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.bugs Subject: bug#13741: [PATCH] test-suite: eq-ness of numbers, characters is unspecified Date: Fri, 01 Mar 2013 11:10:03 -0500 Message-ID: <87bob3umn8.fsf@tines.lan> References: <87ip5pnpyd.fsf@tines.lan> <1361238914-14823-1-git-send-email-mandyke@gmail.com> <87bobgop7z.fsf@tines.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1362154269 23578 80.91.229.3 (1 Mar 2013 16:11:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Mar 2013 16:11:09 +0000 (UTC) Cc: 13741@debbugs.gnu.org To: Daniel Hartwig Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Fri Mar 01 17:11:32 2013 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UBSYU-0000Uh-C8 for guile-bugs@m.gmane.org; Fri, 01 Mar 2013 17:11:30 +0100 Original-Received: from localhost ([::1]:43528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBSY8-0006e2-RQ for guile-bugs@m.gmane.org; Fri, 01 Mar 2013 11:11:08 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBSY2-0006ds-Fo for bug-guile@gnu.org; Fri, 01 Mar 2013 11:11:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UBSXz-0005Nn-Kq for bug-guile@gnu.org; Fri, 01 Mar 2013 11:11:02 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBSXz-0005Nh-HW for bug-guile@gnu.org; Fri, 01 Mar 2013 11:10:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UBSZx-00042S-P7 for bug-guile@gnu.org; Fri, 01 Mar 2013 11:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark H Weaver Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 01 Mar 2013 16:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13741 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 13741-submit@debbugs.gnu.org id=B13741.136215435115483 (code B ref 13741); Fri, 01 Mar 2013 16:13:01 +0000 Original-Received: (at 13741) by debbugs.gnu.org; 1 Mar 2013 16:12:31 +0000 Original-Received: from localhost ([127.0.0.1]:58330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UBSZR-00041e-4B for submit@debbugs.gnu.org; Fri, 01 Mar 2013 11:12:30 -0500 Original-Received: from world.peace.net ([96.39.62.75]:41001) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UBSZO-00041W-Jd for 13741@debbugs.gnu.org; Fri, 01 Mar 2013 11:12:27 -0500 Original-Received: from 209-6-91-212.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.91.212] helo=tines.lan) by world.peace.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1UBSXI-000596-ES; Fri, 01 Mar 2013 11:10:16 -0500 In-Reply-To: <87bobgop7z.fsf@tines.lan> (Mark H. Weaver's message of "Tue, 19 Feb 2013 00:19:12 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:6811 Archived-At: I wrote: > Daniel Hartwig writes: >> * test-suite/tests/00-socket.test: >> * test-suite/tests/alist.test: >> * test-suite/tests/elisp.test: >> * test-suite/tests/encoding-iso88591.test: >> * test-suite/tests/encoding-iso88597.test: >> * test-suite/tests/encoding-utf8.test: >> * test-suite/tests/hash.test: >> * test-suite/tests/i18n.test: >> * test-suite/tests/modules.test: >> * test-suite/tests/ports.test: >> * test-suite/tests/srfi-35.test: Make tests use eqv? instead of eq? when >> comparing numbers, characters. Checked also for similar uses of >> assq[-ref]. >> >> * test-suite/tests/vlist.test ("vhash-delete honors HASH"): Change test >> to use eqv-ness, not eq-ness, which should not impact its purpose as >> these two are equivalent for strings. > > I think we should apply this patch. Although we can currently rely on > 'eq?' working properly for fixnums and characters in Guile, misuse of > 'eq?' is widespread, and our misuse of it in our own code contributes to > the confusion. IMO we should set a better example. > > What do other people think? Having heard no objections over 10 days, I went ahead and pushed this. Thanks! Mark