Bug#649718: Issues with alignment and m68k register naming

Bug#649718: Issues with alignment and m68k register naming

[Rob Browning]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

[If possible, please preserve the -forwarded address in any replies.]

This was reported to Debian a bit back, and I thought it might be
appropriate for consideration upstream.

Further details can be found here:

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649718

And here's a standalone version of the patch from the debdiff there:


[-- Attachment #2: fix-alignment-and-m68k-register.diff --]
[-- Type: text/x-diff, Size: 1802 bytes --]

From schwab@linux-m68k.org Mon May 12 18:37:51 2014
From: Andreas Schwab <schwab@linux-m68k.org>
Message-ID: <87y4y7uf4y.fsf@igel.home>
To: Thorsten Glaser <t.glaser@tarent.de>
Cc: Manoj Srivastava <srivasta@debian.org>, debian-68k@lists.debian.org
Date: Mon, 12 May 2014 18:37:49 +0200
X-Original-Subject: Re: Guile language support in make
Subject: Fix alignment and registers for m68k

Fix bogus alignment assumptions (on some architectures, “natural”
alignment is not used, which means even an uint64_t is possibly
unaligned, or aligned to only a 2 byte (m68k) or 4 byte boundary).

Also, fix register name for m68k.
--

Thorsten Glaser <t.glaser@tarent.de> writes:

> and the guile-2.0 Build-Depends on m68k because guile does not
> work there (and nobody appears capable enough to debug it)?

--- a/libguile/gsubr.c
+++ b/libguile/gsubr.c
@@ -213,7 +213,7 @@
 */
 static const struct
 {
-  scm_t_uint64 dummy; /* ensure 8-byte alignment; perhaps there's a better way */
+  scm_t_uint64 dummy SCM_ALIGNED (sizeof (scm_t_uint64)); /* ensure 8-byte alignment; perhaps there's a better way */
   const scm_t_uint8 bytes[121 * (sizeof (struct scm_objcode) + 16
                                  + sizeof (struct scm_objcode) + 32)];
 } raw_bytecode = {
@@ -317,7 +317,7 @@ static const struct
 
 static const struct
 {
-  scm_t_uint64 dummy; /* alignment */
+  scm_t_uint64 dummy SCM_ALIGNED (sizeof (scm_t_uint64)); /* alignment */
   scm_t_cell cells[121 * 2]; /* 11*11 double cells */
 } objcode_cells = {
   0,
--- a/libguile/vm-engine.h
+++ b/libguile/vm-engine.h
@@ -74,7 +74,7 @@
 #define FP_REG asm("%r16")
 #endif
 #ifdef __mc68000__
-#define IP_REG asm("a5")
+#define IP_REG asm("a3")
 #define SP_REG asm("a4")
 #define FP_REG
 #endif

[-- Attachment #3: Type: text/plain, Size: 198 bytes --]


-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

bug#18468: Issues with alignment and m68k register naming

[Mark H Weaver]

>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649718

I pushed slightly different fixes to the stable-2.0 branch,
commits 97c520fd3ff5ae0305b6d236e0bc31f794a6cce6 and
156119b0223cf14d335ebda84701a69b2ba95757.

I'm closing this bug now.

     Thanks!
       Mark