* bug#60971: GNU Guile 3.0.9rc1 available for testing! [not found] ` <rmiy1pu3a7e.fsf@s1.lexort.com> @ 2023-01-23 10:48 ` Ludovic Courtès [not found] ` <87h6wh34t0.fsf@gnu.org> 1 sibling, 0 replies; 4+ messages in thread From: Ludovic Courtès @ 2023-01-23 10:48 UTC (permalink / raw) To: Greg Troxel; +Cc: 60971, lloda, guile-devel@gnu.org [-- Attachment #1: Type: text/plain, Size: 510 bytes --] Hi, Greg Troxel <gdt@lexort.com> skribis: > lloda <lloda@sarc.name> writes: > >> This looks like https://debbugs.gnu.org/60971 <https://debbugs.gnu.org/60971> on mac os. > > Yes, it does. > > My quick reaction is that if the POSIX-required macros operation on > system types that might be struct, then faking up ints for testing is > unsound. > > Maybe only do verify if guile has to define macros, and don't try to > test the OS? So something like the patch below? Thanks, Ludo’. [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: Type: text/x-patch, Size: 314 bytes --] diff --git a/libguile/posix.c b/libguile/posix.c index 74c743119..0b1fe2637 100644 --- a/libguile/posix.c +++ b/libguile/posix.c @@ -105,8 +105,8 @@ # else # define W_EXITCODE(ret, sig) ((ret) << 8 | (sig)) # endif -#endif verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127); +#endif #include <signal.h> ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <87h6wh34t0.fsf@gnu.org>]
* bug#60971: GNU Guile 3.0.9rc1 available for testing! [not found] ` <87h6wh34t0.fsf@gnu.org> @ 2023-01-23 18:04 ` lloda 2023-01-23 18:47 ` Aleix Conchillo Flaqué [not found] ` <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name> 2 siblings, 0 replies; 4+ messages in thread From: lloda @ 2023-01-23 18:04 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 60971, guile-devel@gnu.org, Greg Troxel lgtm, no other issues on mac os. thanks Daniel ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#60971: GNU Guile 3.0.9rc1 available for testing! [not found] ` <87h6wh34t0.fsf@gnu.org> 2023-01-23 18:04 ` lloda @ 2023-01-23 18:47 ` Aleix Conchillo Flaqué [not found] ` <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name> 2 siblings, 0 replies; 4+ messages in thread From: Aleix Conchillo Flaqué @ 2023-01-23 18:47 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 60971, lloda, guile-devel@gnu.org, Greg Troxel [-- Attachment #1: Type: text/plain, Size: 715 bytes --] On Mon, Jan 23, 2023 at 2:48 AM Ludovic Courtès <ludo@gnu.org> wrote: > Hi, > > Greg Troxel <gdt@lexort.com> skribis: > > > lloda <lloda@sarc.name> writes: > > > >> This looks like https://debbugs.gnu.org/60971 < > https://debbugs.gnu.org/60971> on mac os. > > > > Yes, it does. > > > > My quick reaction is that if the POSIX-required macros operation on > > system types that might be struct, then faking up ints for testing is > > unsound. > > > > Maybe only do verify if guile has to define macros, and don't try to > > test the OS? > > So something like the patch below? > Oh, I missed the other report. Yes, this works on macOS as just reported by Daniel. No other issues. Aleix [-- Attachment #2: Type: text/html, Size: 1706 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name>]
* bug#60971: build failure of v3.0.9rc1 on mac os 12.6 [not found] ` <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name> @ 2023-01-23 21:59 ` Ludovic Courtès 0 siblings, 0 replies; 4+ messages in thread From: Ludovic Courtès @ 2023-01-23 21:59 UTC (permalink / raw) To: lloda; +Cc: 60971-done, Greg Troxel, guile-devel@gnu.org lloda <lloda@sarc.name> skribis: > lgtm, no other issues on mac os. Awesome, pushed as 9b20ca275dba758a194073936cde7c95311bd51e. Ludo’. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-23 21:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <87v8l15hb2.fsf@inria.fr>
[not found] ` <rmiy1pv48rj.fsf@s1.lexort.com>
[not found] ` <562CD6BE-42D3-4D4C-AB4C-2B4A5341F525@sarc.name>
[not found] ` <rmiy1pu3a7e.fsf@s1.lexort.com>
2023-01-23 10:48 ` bug#60971: GNU Guile 3.0.9rc1 available for testing! Ludovic Courtès
[not found] ` <87h6wh34t0.fsf@gnu.org>
2023-01-23 18:04 ` lloda
2023-01-23 18:47 ` Aleix Conchillo Flaqué
[not found] ` <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name>
2023-01-23 21:59 ` bug#60971: build failure of v3.0.9rc1 on mac os 12.6 Ludovic Courtès
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).