unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Greg Troxel <gdt@lexort.com>
Cc: 60971@debbugs.gnu.org, lloda <lloda@sarc.name>,
	"guile-devel@gnu.org" <guile-devel@gnu.org>
Subject: bug#60971: GNU Guile 3.0.9rc1 available for testing!
Date: Mon, 23 Jan 2023 11:48:11 +0100	[thread overview]
Message-ID: <87h6wh34t0.fsf__29581.3608727016$1674470976$gmane$org@gnu.org> (raw)
In-Reply-To: <rmiy1pu3a7e.fsf@s1.lexort.com> (Greg Troxel's message of "Sun, 22 Jan 2023 09:39:17 -0500")

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Hi,

Greg Troxel <gdt@lexort.com> skribis:

> lloda <lloda@sarc.name> writes:
>
>> This looks like https://debbugs.gnu.org/60971 <https://debbugs.gnu.org/60971> on mac os.
>
> Yes, it does.
>
> My quick reaction is that if the POSIX-required macros operation on
> system types that might be struct, then faking up ints for testing is
> unsound.
>
> Maybe only do verify if guile has to define macros, and don't try to
> test the OS?

So something like the patch below?

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 314 bytes --]

diff --git a/libguile/posix.c b/libguile/posix.c
index 74c743119..0b1fe2637 100644
--- a/libguile/posix.c
+++ b/libguile/posix.c
@@ -105,8 +105,8 @@
 # else
 #  define W_EXITCODE(ret, sig)   ((ret) << 8 | (sig))
 # endif
-#endif
 verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127);
+#endif
 
 
 #include <signal.h>

       reply	other threads:[~2023-01-23 10:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87v8l15hb2.fsf@inria.fr>
     [not found] ` <rmiy1pv48rj.fsf@s1.lexort.com>
     [not found]   ` <562CD6BE-42D3-4D4C-AB4C-2B4A5341F525@sarc.name>
     [not found]     ` <rmiy1pu3a7e.fsf@s1.lexort.com>
2023-01-23 10:48       ` Ludovic Courtès [this message]
     [not found]       ` <87h6wh34t0.fsf@gnu.org>
2023-01-23 18:04         ` bug#60971: GNU Guile 3.0.9rc1 available for testing! lloda
2023-01-23 18:47         ` Aleix Conchillo Flaqué
     [not found]         ` <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name>
2023-01-23 21:59           ` bug#60971: build failure of v3.0.9rc1 on mac os 12.6 Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87h6wh34t0.fsf__29581.3608727016$1674470976$gmane$org@gnu.org' \
    --to=ludo@gnu.org \
    --cc=60971@debbugs.gnu.org \
    --cc=gdt@lexort.com \
    --cc=guile-devel@gnu.org \
    --cc=lloda@sarc.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).