unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* bug#60971: build failure of v3.0.9rc1 on mac os 12.6
@ 2023-01-20 19:16 lloda
  0 siblings, 0 replies; 5+ messages in thread
From: lloda @ 2023-01-20 19:16 UTC (permalink / raw)
  To: 60971



Hello,

v3.0.9rc1 fails on mac os 12.6.2 & gcc 12.2 or clang 14, same error in either case. gcc's error is:

------------------------------------
CC       libguile_3.0_la-posix.lo
In file included from ../../../src/guile4/libguile/posix.c:82:
../../../src/guile4/libguile/posix.c:109:9: error: lvalue required as unary '&' operand
  109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127);
      |         ^~~~~~~~~~~
../../../src/guile4/lib/verify.h:213:57: note: in definition of macro '_GL_VERIFY'
  213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, DIAGNOSTIC)
      |                                                         ^
../../../src/guile4/libguile/posix.c:109:1: note: in expansion of macro 'verify'
  109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127);
      | ^~~~~~
../../../src/guile4/libguile/posix.c:109:9: error: expression in static assertion is not an integer
  109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127);
      |         ^~~~~~~~~~~
../../../src/guile4/lib/verify.h:213:57: note: in definition of macro '_GL_VERIFY'
  213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, DIAGNOSTIC)
      |                                                         ^
../../../src/guile4/libguile/posix.c:109:1: note: in expansion of macro 'verify'
  109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127);
      | ^~~~~~
------------------------------------

The problematic section in libguile/posix.c

...

#if HAVE_SYS_WAIT_H
# include <sys/wait.h>
#endif
#ifndef WEXITSTATUS
# define WEXITSTATUS(stat_val) ((unsigned)(stat_val) >> 8)
#endif
#ifndef WIFEXITED
# define WIFEXITED(stat_val) (((stat_val) & 255) == 0)
#endif

#ifndef W_EXITCODE
/* Macro for constructing a status value.  Found in glibc.  */
# ifdef _WIN32                            /* see Gnulib's posix-w32.h */
#  define W_EXITCODE(ret, sig)   (ret)
# else
#  define W_EXITCODE(ret, sig)   ((ret) << 8 | (sig))
# endif
#endif
verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127);
...

adding -o .libs/libguile_3.0_la-posix.i -E to the build line shows line 109 as

_Static_assert ( (((*(int *)&((( 127 ) << 8 | ( 0 )))) >> 8) & 0x000000ff) == 127, "verify (" "WEXITSTATUS (W_EXITCODE (127, 0)) == 127" ")");
                            ^

forcing redefinition of WEXITSTATUS shows the previous definition at /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/wait.h

...

#if defined(_POSIX_C_SOURCE) && !defined(_DARWIN_C_SOURCE)
#define _W_INT(i)       (i)
#else
#define _W_INT(w)       (*(int *)&(w))  /* convert union wait to int */   <------------- problem
#define WCOREFLAG       0200
#endif /* (_POSIX_C_SOURCE && !_DARWIN_C_SOURCE) */

/* These macros are permited, as they are in the implementation namespace */
#define _WSTATUS(x)     (_W_INT(x) & 0177)
#define _WSTOPPED       0177            /* _WSTATUS if process is stopped */

/*
 * [XSI] The <sys/wait.h> header shall define the following macros for
 * analysis of process status values
 */
#if __DARWIN_UNIX03
#define WEXITSTATUS(x)  ((_W_INT(x) >> 8) & 0x000000ff)
#else /* !__DARWIN_UNIX03 */
#define WEXITSTATUS(x)  (_W_INT(x) >> 8)
#endif /* !__DARWIN_UNIX03 */
/* 0x13 == SIGCONT */
#define WSTOPSIG(x)     (_W_INT(x) >> 8)
#define WIFCONTINUED(x) (_WSTATUS(x) == _WSTOPPED && WSTOPSIG(x) == 0x13)
#define WIFSTOPPED(x)   (_WSTATUS(x) == _WSTOPPED && WSTOPSIG(x) != 0x13)
#define WIFEXITED(x)    (_WSTATUS(x) == 0)
#define WIFSIGNALED(x)  (_WSTATUS(x) != _WSTOPPED && _WSTATUS(x) != 0)
#define WTERMSIG(x)     (_WSTATUS(x))
#if (!defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE))
#define WCOREDUMP(x)    (_W_INT(x) & WCOREFLAG)

#define W_EXITCODE(ret, sig)    ((ret) << 8 | (sig))
#define W_STOPCODE(sig)         ((sig) << 8 | _WSTOPPED)
#endif /* (!defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)) */

...

so that's the problem, but I'm not sure what the solution is. The way it's
written, W_EXITCODE() is always going to give up a number...

Thanks

  Daniel






^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#60971: GNU Guile 3.0.9rc1 available for testing!
       [not found]     ` <rmiy1pu3a7e.fsf@s1.lexort.com>
@ 2023-01-23 10:48       ` Ludovic Courtès
       [not found]       ` <87h6wh34t0.fsf@gnu.org>
  1 sibling, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2023-01-23 10:48 UTC (permalink / raw)
  To: Greg Troxel; +Cc: 60971, lloda, guile-devel@gnu.org

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Hi,

Greg Troxel <gdt@lexort.com> skribis:

> lloda <lloda@sarc.name> writes:
>
>> This looks like https://debbugs.gnu.org/60971 <https://debbugs.gnu.org/60971> on mac os.
>
> Yes, it does.
>
> My quick reaction is that if the POSIX-required macros operation on
> system types that might be struct, then faking up ints for testing is
> unsound.
>
> Maybe only do verify if guile has to define macros, and don't try to
> test the OS?

So something like the patch below?

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 314 bytes --]

diff --git a/libguile/posix.c b/libguile/posix.c
index 74c743119..0b1fe2637 100644
--- a/libguile/posix.c
+++ b/libguile/posix.c
@@ -105,8 +105,8 @@
 # else
 #  define W_EXITCODE(ret, sig)   ((ret) << 8 | (sig))
 # endif
-#endif
 verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127);
+#endif
 
 
 #include <signal.h>

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#60971: GNU Guile 3.0.9rc1 available for testing!
       [not found]       ` <87h6wh34t0.fsf@gnu.org>
@ 2023-01-23 18:04         ` lloda
  2023-01-23 18:47         ` Aleix Conchillo Flaqué
       [not found]         ` <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name>
  2 siblings, 0 replies; 5+ messages in thread
From: lloda @ 2023-01-23 18:04 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 60971, guile-devel@gnu.org, Greg Troxel


lgtm, no other issues on mac os.

thanks

  Daniel







^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#60971: GNU Guile 3.0.9rc1 available for testing!
       [not found]       ` <87h6wh34t0.fsf@gnu.org>
  2023-01-23 18:04         ` lloda
@ 2023-01-23 18:47         ` Aleix Conchillo Flaqué
       [not found]         ` <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name>
  2 siblings, 0 replies; 5+ messages in thread
From: Aleix Conchillo Flaqué @ 2023-01-23 18:47 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 60971, lloda, guile-devel@gnu.org, Greg Troxel

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

On Mon, Jan 23, 2023 at 2:48 AM Ludovic Courtès <ludo@gnu.org> wrote:

> Hi,
>
> Greg Troxel <gdt@lexort.com> skribis:
>
> > lloda <lloda@sarc.name> writes:
> >
> >> This looks like https://debbugs.gnu.org/60971 <
> https://debbugs.gnu.org/60971> on mac os.
> >
> > Yes, it does.
> >
> > My quick reaction is that if the POSIX-required macros operation on
> > system types that might be struct, then faking up ints for testing is
> > unsound.
> >
> > Maybe only do verify if guile has to define macros, and don't try to
> > test the OS?
>
> So something like the patch below?
>

Oh, I missed the other report. Yes, this works on macOS as just reported by
Daniel. No other issues.

Aleix

[-- Attachment #2: Type: text/html, Size: 1706 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#60971: build failure of v3.0.9rc1 on mac os 12.6
       [not found]         ` <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name>
@ 2023-01-23 21:59           ` Ludovic Courtès
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2023-01-23 21:59 UTC (permalink / raw)
  To: lloda; +Cc: 60971-done, Greg Troxel, guile-devel@gnu.org

lloda <lloda@sarc.name> skribis:

> lgtm, no other issues on mac os.

Awesome, pushed as 9b20ca275dba758a194073936cde7c95311bd51e.

Ludo’.





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-01-23 21:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <87v8l15hb2.fsf@inria.fr>
     [not found] ` <rmiy1pv48rj.fsf@s1.lexort.com>
     [not found]   ` <562CD6BE-42D3-4D4C-AB4C-2B4A5341F525@sarc.name>
     [not found]     ` <rmiy1pu3a7e.fsf@s1.lexort.com>
2023-01-23 10:48       ` bug#60971: GNU Guile 3.0.9rc1 available for testing! Ludovic Courtès
     [not found]       ` <87h6wh34t0.fsf@gnu.org>
2023-01-23 18:04         ` lloda
2023-01-23 18:47         ` Aleix Conchillo Flaqué
     [not found]         ` <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name>
2023-01-23 21:59           ` bug#60971: build failure of v3.0.9rc1 on mac os 12.6 Ludovic Courtès
2023-01-20 19:16 lloda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).