From: Gregory Heytings <gregory@heytings.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: "Mattias Engdegård" <mattias.engdegard@gmail.com>,
emacs-devel <emacs-devel@gnu.org>,
"Juri Linkov" <juri@linkov.net>
Subject: Re: New unwind-protect byte-compiler warning
Date: Tue, 04 Apr 2023 12:32:41 +0000 [thread overview]
Message-ID: <cb05c7fc8e106faaec19@heytings.org> (raw)
In-Reply-To: <87fs9ghr96.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
>
> This one:
>
> In mouse-wheel-global-text-scale:
> mwheel.el:450:6: Warning: ‘unwind-protect’ without unwind forms
>
> is because weʼre protecting against errors from
> `global-text-scale-adjust', but unlike `text-scale-{in,de}crease', that
> doesnʼt signal an error when you reach the scale limit.
>
> Juri, we can add an unwind form of `t', or switch it to
> `condition-case', whichever you prefer (Iʼm assuming perhaps
> pessimistically that `global-text-scale-adjust' might signal in future).
>
The byte-compiler warning is correct, this is a copy-paste error in
e0488f89d1, the unwind-protect is unnecessary and can be removed.
next prev parent reply other threads:[~2023-04-04 12:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 8:01 New unwind-protect byte-compiler warning Mattias Engdegård
2023-03-30 10:08 ` Emanuel Berg
2023-04-01 22:56 ` Basil L. Contovounesios
2023-04-04 10:32 ` Robert Pluim
2023-04-04 11:20 ` Mattias Engdegård
2023-04-04 12:26 ` Robert Pluim
2023-04-04 12:32 ` Gregory Heytings [this message]
2023-04-04 16:10 ` Juri Linkov
2023-04-07 17:40 ` Mattias Engdegård
2023-04-09 14:20 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb05c7fc8e106faaec19@heytings.org \
--to=gregory@heytings.org \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=mattias.engdegard@gmail.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.