all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: New unwind-protect byte-compiler warning
Date: Sun, 09 Apr 2023 16:20:54 +0200	[thread overview]
Message-ID: <87cz4dxhkp.fsf@gmx.de> (raw)
In-Reply-To: <25A5C1A9-0321-43B6-A359-5659DB79F5F8@gmail.com> ("Mattias Engdegård"'s message of "Fri, 7 Apr 2023 19:40:03 +0200")

Mattias Engdegård <mattias.engdegard@gmail.com> writes:

Hi Mattias,

> Also thanks to Michael who fixed a few tramp-related warnings. Michael, here's a bonus for you uncovered by an experimental compiler change (that I didn't end up applying):
>
>> (defun tramp-sshfs-handle-insert-file-contents
>>   (filename &optional visit beg end replace)
>>   "Like `insert-file-contents' for Tramp files."
>>   (setq filename (expand-file-name filename))
>>   (let (signal-hook-function result)
>>     (unwind-protect
>>         (setq result
>> 	      (insert-file-contents
>> 	       (tramp-fuse-local-file-name filename) visit beg end replace))
>>       (when visit (setq buffer-file-name filename))
>>       (cons filename (cdr result)))))
>
> The last unwind form seems to expect its value to be used, but it is really discarded. Perhaps it's just a misplaced bracket?

Yes, that's an error, uncovered yet. Thanks!

I've fixed this in master.

Best regards, Michael.



      reply	other threads:[~2023-04-09 14:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30  8:01 New unwind-protect byte-compiler warning Mattias Engdegård
2023-03-30 10:08 ` Emanuel Berg
2023-04-01 22:56 ` Basil L. Contovounesios
2023-04-04 10:32 ` Robert Pluim
2023-04-04 11:20   ` Mattias Engdegård
2023-04-04 12:26     ` Robert Pluim
2023-04-04 12:32   ` Gregory Heytings
2023-04-04 16:10   ` Juri Linkov
2023-04-07 17:40 ` Mattias Engdegård
2023-04-09 14:20   ` Michael Albinus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz4dxhkp.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=mattias.engdegard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.