Re: New unwind-protect byte-compiler warning

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Thu, 30 Mar 2023 10:01:42 +0200, Mattias Engdegård <mattias.engdegard@gmail.com> said:

    Mattias> On master, the byte-compiler now warns about `unwind-protect` forms lacking actual unwinding code, which is very often a mistake. An Emacs build currently yields about 30 warnings of this kind.
    Mattias> I'm mostly going to wait for those with good knowledge about the code causing each warning to deal with it. Tell me if I can be of further help. There's no strong urgency.

    Mattias> This will eventually leave some warnings claimed by no-one for me to take on, which will be done in a conservative way, maybe after a week.

This one:

    In mouse-wheel-global-text-scale:
    mwheel.el:450:6: Warning: ‘unwind-protect’ without unwind forms

is because weʼre protecting against errors from
`global-text-scale-adjust', but unlike `text-scale-{in,de}crease',
that doesnʼt signal an error when you reach the scale limit.

Juri, we can add an unwind form of `t', or switch it to
`condition-case', whichever you prefer (Iʼm assuming perhaps
pessimistically that `global-text-scale-adjust' might signal in
future).

Robert
--