From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: New unwind-protect byte-compiler warning Date: Tue, 04 Apr 2023 12:32:41 +0000 Message-ID: References: <0106E951-59EB-42C9-8F99-4182F56C6311@gmail.com> <87fs9ghr96.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="G23LDMSsTk" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14373"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , emacs-devel , Juri Linkov To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 04 14:33:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjfqh-0003Vt-5y for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Apr 2023 14:33:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjfqD-0003Be-7B; Tue, 04 Apr 2023 08:32:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjfqB-0003Al-O5 for emacs-devel@gnu.org; Tue, 04 Apr 2023 08:32:47 -0400 Original-Received: from heytings.org ([95.142.160.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjfq9-0004HC-Pb for emacs-devel@gnu.org; Tue, 04 Apr 2023 08:32:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1680611562; bh=qm93Ye7ot7aTE8NOSJy54cTtA4p1wC9+QfQrreprx9g=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=E69wjVbl4gnlHw+brJzz+q62kofEV6JBcvoHgY42E5kGk6XAEiFvCV1ZMrI3def4l 22byY0YbrhdvzlJoifC2cWCubMqfXwKPnMhUIrU8O9VvCsyD58dk/VL4GYmsgWUvWj Y+4rW6xzLM/X7xm9QTmOWi9KavQOyQfbY/HslskXguMB+6kPJRA1i/chXFAxETqQ6v tbRnh49mBeuRmLzOvrfFybZAI/Nz2OpPKl/GsIbxgchVha0mZ5WNR5j5eX/KX3Oo/M brVb9rL9XfYWobqudLCykbd55QRLcU3LcZ7YmMvM5Pq5TX4pQJy9zC41IJTOJP3kXK LbglAq8rNjR8g== In-Reply-To: <87fs9ghr96.fsf@gmail.com> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305104 Archived-At: --G23LDMSsTk Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable > > This one: > > In mouse-wheel-global-text-scale: > mwheel.el:450:6: Warning: =E2=80=98unwind-protect=E2=80=99 without unw= ind forms > > is because we=CA=BCre protecting against errors from=20 > `global-text-scale-adjust', but unlike `text-scale-{in,de}crease', that= =20 > doesn=CA=BCt signal an error when you reach the scale limit. > > Juri, we can add an unwind form of `t', or switch it to=20 > `condition-case', whichever you prefer (I=CA=BCm assuming perhaps=20 > pessimistically that `global-text-scale-adjust' might signal in future). > The byte-compiler warning is correct, this is a copy-paste error in=20 e0488f89d1, the unwind-protect is unnecessary and can be removed. --G23LDMSsTk--