From: Kjartan Oli Agustsson <kjartanoli@outlook.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 55825@debbugs.gnu.org
Subject: bug#55825: [PATCH] Reconvert EPUB buffers when user CSS is changed
Date: Tue, 07 Jun 2022 21:40:09 +0000 [thread overview]
Message-ID: <GV1P193MB23107DCDEF696FFE031D15D2DFA59@GV1P193MB2310.EURP193.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <87pmjkn6df.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Did you mean to remove the doc-view-mutool-user-stylesheet user option
> instead of renaming it?
I did rename it, I believe I also moved it a few lines down as well to
make sure some other variable/function was defined first (It's been a
while since I wrote that part of the patch, I can't remember the exact
reason).
> In any case, the patch has the following warnings:
>
> In doc-view--epub-reconvert:
> doc-view.el:238:44: Warning: Unused lexical argument `event'
Yes, I'm not sure what the best way to get rid of this one is. If
`doc-view--epub-reconvert' doesn't take `event' as an argument it will
cause a warning about being called with to many arguments when used as
the callback for the file watcher set up in
`doc-view-custom-set-epub-user-stylesheet'
> In doc-view-custom-set-epub-user-stylesheet:
> doc-view.el:256:16: Warning: reference to free variable `doc-view-epub-user-stylesheet'
If I recall correctly then defining the variable before the function
would cause that definition to either emit a warning, or error, because
the function (which is passed as the `:set' argument to defcustom)
hasn't been defined when said defcustom is evaluated. Any advice on how
to get rid of either of these warnings would be greatly appreciated.
--
Kjartan Óli Ágústsson
GPG Key fingerprint: 4801 0D71 49C0 1DD6 E5FD 6AC9 D757 2FE3 605E E6B0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 691 bytes --]
next prev parent reply other threads:[~2022-06-07 21:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 19:20 bug#55825: [PATCH] Reconvert EPUB buffers when user CSS is changed Kjartan Oli Agustsson
2022-06-07 9:57 ` Lars Ingebrigtsen
2022-06-07 21:40 ` Kjartan Oli Agustsson [this message]
2022-06-08 2:35 ` Eli Zaretskii
2022-06-07 11:06 ` Eli Zaretskii
2022-06-07 21:51 ` Kjartan Oli Agustsson
2022-06-08 2:31 ` Eli Zaretskii
2022-06-08 23:10 ` Kjartan Oli Agustsson
2022-06-08 23:28 ` Kjartan Oli Agustsson
2022-06-09 5:28 ` Eli Zaretskii
2022-06-26 12:33 ` Kjartan Oli Agustsson
2022-06-26 15:53 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P193MB23107DCDEF696FFE031D15D2DFA59@GV1P193MB2310.EURP193.PROD.OUTLOOK.COM \
--to=kjartanoli@outlook.com \
--cc=55825@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.