From: Eli Zaretskii <eliz@gnu.org>
To: Kjartan Oli Agustsson <kjartanoli@outlook.com>
Cc: 55825@debbugs.gnu.org
Subject: bug#55825: [PATCH] Reconvert EPUB buffers when user CSS is changed
Date: Tue, 07 Jun 2022 14:06:10 +0300 [thread overview]
Message-ID: <83pmjk7mxp.fsf@gnu.org> (raw)
In-Reply-To: <GV1P193MB2310985FE85FEA2FBFA9B20EDFA29@GV1P193MB2310.EURP193.PROD.OUTLOOK.COM> (message from Kjartan Oli Agustsson on Mon, 06 Jun 2022 19:20:04 +0000)
> From: Kjartan Oli Agustsson <kjartanoli@outlook.com>
> Date: Mon, 06 Jun 2022 19:20:04 +0000
>
> +(defun doc-view-custom-set-epub-user-stylesheet (option-name new-value)
> + "Setter for `doc-view-epub-user-stylesheet'.
> +
> +Reconverts existing epub buffers when the file used as a user
> +stylesheet is switched."
> + (set-default option-name new-value)
> + (file-notify-rm-watch doc-view--epub-stylesheet-watcher)
> + (doc-view--epub-reconvert)
> + (setq doc-view--epub-stylesheet-watcher
> + (when doc-view-epub-user-stylesheet
> + (file-notify-add-watch doc-view-epub-user-stylesheet '(change) #'doc-view--epub-reconvert))))
Are you sure 'change is TRT here? What kinds of changes did you want
to watch in this case (it isn't clear from the doc string or the log
message)? 'change is a synthetic event, and it means slightly
different things with each file-notification back-end, so I wonder
whether 'change is portable enough here?
next prev parent reply other threads:[~2022-06-07 11:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 19:20 bug#55825: [PATCH] Reconvert EPUB buffers when user CSS is changed Kjartan Oli Agustsson
2022-06-07 9:57 ` Lars Ingebrigtsen
2022-06-07 21:40 ` Kjartan Oli Agustsson
2022-06-08 2:35 ` Eli Zaretskii
2022-06-07 11:06 ` Eli Zaretskii [this message]
2022-06-07 21:51 ` Kjartan Oli Agustsson
2022-06-08 2:31 ` Eli Zaretskii
2022-06-08 23:10 ` Kjartan Oli Agustsson
2022-06-08 23:28 ` Kjartan Oli Agustsson
2022-06-09 5:28 ` Eli Zaretskii
2022-06-26 12:33 ` Kjartan Oli Agustsson
2022-06-26 15:53 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pmjk7mxp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55825@debbugs.gnu.org \
--cc=kjartanoli@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.