From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kjartan Oli Agustsson Newsgroups: gmane.emacs.bugs Subject: bug#55825: [PATCH] Reconvert EPUB buffers when user CSS is changed Date: Tue, 07 Jun 2022 21:40:09 +0000 Message-ID: References: <87pmjkn6df.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23608"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.10; emacs 29.0.50 Cc: 55825@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 08 00:59:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyiAl-00060W-G4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jun 2022 00:59:40 +0200 Original-Received: from localhost ([::1]:37394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyiAk-0007hB-Dc for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jun 2022 18:59:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyh7K-0007Iv-8n for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 17:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47853) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyh7J-00030y-RI for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 17:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nyh7J-0006Uf-Qb for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 17:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kjartan Oli Agustsson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jun 2022 21:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55825 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55825-submit@debbugs.gnu.org id=B55825.165463866624892 (code B ref 55825); Tue, 07 Jun 2022 21:52:01 +0000 Original-Received: (at 55825) by debbugs.gnu.org; 7 Jun 2022 21:51:06 +0000 Original-Received: from localhost ([127.0.0.1]:41750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyh6P-0006Sz-WD for submit@debbugs.gnu.org; Tue, 07 Jun 2022 17:51:06 -0400 Original-Received: from mail-oln040092075067.outbound.protection.outlook.com ([40.92.75.67]:21413 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyh6I-0006SN-Gf for 55825@debbugs.gnu.org; Tue, 07 Jun 2022 17:51:04 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BXKgA83f96cshqq/4yZbrHcln+3lTEkcSyO39d46fKPqTgNcKS8TtSlKp23IysjzZjS1gwlSTPGQYMp6LMBtZfE7/GDQHbwlsH4SpDMjVmTVibhMuQsKFzat/99DtrexjgxTvdYJhBQNDPPlD4C5zVCT5iVySpl87wfghEsNwEWH1s7hogkKjbIXDx9vRruq0LrIruLgQeQ2gg+tYUcyyAmwXzritsbW2sXBZjII/KMFr3CmUGWBNbc/z5gkDdVU4nXfGdJwaopLguQ+DKPQzK/onC7vpO0L7HAAue5WdN+oVlSAdD1oHfdksSgI+FpHZkquJuRFwIjh3Djh12x1GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WamqA/Ao15BQnEXg3g8NPbenKYZUiRp+fy1WoNcasL4=; b=N5tnKLblmTE1+sNRyyY8/t1nhyqb5xCK73jsZV4QG0mgJ7+1M/jSN0l3fXs1hmQtI0ir/qQN8VqeGCc5b4rsO9D+DJzgZNjzM9tbnWkakm7NfwI/HsHWzUG7HWiuepWf5w4wMWnklk+g9VR6bVpzlUxNJvBPSd7ZmSKC/A81nH4OezkeRaIal3oQNP/1GBpb2gzEGReCtn0GVkBhe2qXUbz2QKpnhiEXLnRCPBw1GXl5YfBR+iFFL1iggeuWeBubuOvnWId8bmZc3rNZ6hONHA/C8Un27RdsNSQDa45g+iaAVWwbSnlMKN+a9BBptXNCWd44Em0hkIP0ZfXTA7gPww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WamqA/Ao15BQnEXg3g8NPbenKYZUiRp+fy1WoNcasL4=; b=JSTZuX6a7j6jpSEd23roXaOnhV6OzBMmsCeoi/HtP8DSK7SkrywsJFgdEuoxXNmnjWyMml2gLEXUGteWkP7E4zyYhrlmGp/vwqbOcaLokJqZ2bU1r4lRdpDtFR0ryaPt48MVPNKifGAoBT/JGRNF5ZRz5Un89zK7Eab6o+6H/Rk27Sa/c4gVrj3zjWdZ+/0fbyJKVYevmYS2aB9fPWocvBhN4OvhOcHsdqRqyg8uyJVu/8JAUEZS8FdySufGP3zvP7ygd8BUxW/crcev8aKCjDmMp5DlgKmxiBhRgqU9s8A5zk78FdJ5Ib/GeDZaAGG85TNY26c/Op5am7lhEjXc/Q== Original-Received: from GV1P193MB2310.EURP193.PROD.OUTLOOK.COM (2603:10a6:150:2a::20) by AS8P193MB1831.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:3f0::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Tue, 7 Jun 2022 21:50:51 +0000 Original-Received: from GV1P193MB2310.EURP193.PROD.OUTLOOK.COM ([fe80::ec59:f94:e9c4:2f17]) by GV1P193MB2310.EURP193.PROD.OUTLOOK.COM ([fe80::ec59:f94:e9c4:2f17%8]) with mapi id 15.20.5332.012; Tue, 7 Jun 2022 21:50:51 +0000 In-reply-to: <87pmjkn6df.fsf@gnus.org> X-TMN: [NtVdYSkyu264P7LQrTLWV5ZAb33Xz8ht] X-ClientProxiedBy: AM0PR02CA0184.eurprd02.prod.outlook.com (2603:10a6:20b:28e::21) To GV1P193MB2310.EURP193.PROD.OUTLOOK.COM (2603:10a6:150:2a::20) X-Microsoft-Original-Message-ID: <87ee00ywg7.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b08e73c4-2288-4b69-26df-08da48cfc9da X-MS-TrafficTypeDiagnostic: AS8P193MB1831:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G6AT/4DEbvTON7tf7k//SjFdVSFbJe9xjcW8lwhxcpbqfRkSfU7UVGaWsMnAUjqhMgB13LdHQshA6Wvj2HZWH4PeP1MBk0oSWfS/KHbwhx6CwmYiROLEFbsKREBxdlKKiOySjLVr3XfU2KE9wzMWRahA+3kdpquA3k34V7/9vlfyhC5+bx+2OzPEqyUiKKYk4V6ic+1IwimWR6PHvy70JFw2SAJdElsxBnxiHlZqhPJt3E6cHVWWyHXjW0Cyq0hEMfA0/n7V+9it2sRByOzNVL2VhbBTEE2G8KsXf9I7R4ASJn+3c4IQg1B+TuIea1Ldz/zHaMTlOPMfEloGWNRExTmap9C8GdLwokoNx4lF+T9qd1ztx9Ev3VkBKUINlH4aZsMv3oWqb7vU1P+o4Zfvyl/mGdLbfP+Y97RVTd/JCTZ49k/o5yMYkQ1DNdoNgrgS3LX0K7n9N2vjPcCugEfRNodqLDKmt4vMTDbdQWcdlUT9x7/M0oqTTBQ1DEUhRWjs+qA9I/n2pU3SdK/cRXX5ArLaCgz2fFndgOWYpqXu0yiTgpBpxGFogcvwh9dEs7S5cguHfcWCIZNkLoY9IGS27w== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: C8BxZGrrnk3KdH3bAl7X/RJL2t7PtNQISU8W28OaKgyfOz9ge9vzFyKNnZAGn3+1+I31ePavzlOmwIesfa/QIt2fBUvEq1s/O2eO/iTGro7OftvVTg1V+2mNtrQ3IDZZqVZoqz8swF8FgW2CqyPtIjd9ju4rL1lhSav/S2xnH4d1bgmTH4fhwdu/mSyp7IYmluULGuAt5nUmOO/4yVMdEHCUxJ0b/GOP5y5X/5qSIUtAdEWfGxhc8G1Qggcbzy2nVZL9Fi4xfDV7s4YCnyoDUtRinX9zk2UK4vORHdRBg7Lz9by8DHND09zbPGJNlx5oelsonyd86ofdo0eJnxzRHIE4AsGD3QCP014bZEGr0ilQZpzNB5uTFsLqgD0aZmkzpYkxit4jNr6w9xll+s/R+a4MQJnb8TGFhZt7cvN2kU0Qf8lvfDU2lLK4Vr+Qk/3CjSu5Yr/D8OgywVAS9foT6dfxrs+WpOzzTceEV9es8AtVPvqZrBmwcIQyeCMrrKGkJ2i+2BUICG+YE44V9yQudV77PWMS3wosk3Hof4fy3/0KuPkhBNztxJEJMQSzICcQycsAFAUiuKLWIodnh5jQ+HonzuhkW0YiYsi5/BzzQfq5ZoR44Q8AQtfbpmGqGUumTL+rPejW217I1/J2nQuoACQb99bYY79Jehn7Aq+Yvu16ilAO+ifP1WXyXfRnO8D0aQ+sD1lI3G1eYYX6Tfmwt32gLyGP/uu1/Ez//6m/3lI3IxlylRlMbw1tG7 y0EOgKdgP3KnE2Ju9NganAubpi+8fOf865tFlMIej0kZVDAmtP72yzU++YR7OBijBOoUGW+a/rhi0ksht+AQMhvkNXiWipTkFG X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b08e73c4-2288-4b69-26df-08da48cfc9da X-MS-Exchange-CrossTenant-AuthSource: GV1P193MB2310.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2022 21:50:51.1418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P193MB1831 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233935 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Did you mean to remove the doc-view-mutool-user-stylesheet user option > instead of renaming it? I did rename it, I believe I also moved it a few lines down as well to make sure some other variable/function was defined first (It's been a while since I wrote that part of the patch, I can't remember the exact reason). > In any case, the patch has the following warnings: > > In doc-view--epub-reconvert: > doc-view.el:238:44: Warning: Unused lexical argument `event' Yes, I'm not sure what the best way to get rid of this one is. If `doc-view--epub-reconvert' doesn't take `event' as an argument it will cause a warning about being called with to many arguments when used as the callback for the file watcher set up in `doc-view-custom-set-epub-user-stylesheet' > In doc-view-custom-set-epub-user-stylesheet: > doc-view.el:256:16: Warning: reference to free variable `doc-view-epub-us= er-stylesheet' If I recall correctly then defining the variable before the function would cause that definition to either emit a warning, or error, because the function (which is passed as the `:set' argument to defcustom) hasn't been defined when said defcustom is evaluated. Any advice on how to get rid of either of these warnings would be greatly appreciated. =2D-=20 Kjartan =C3=93li =C3=81g=C3=BAstsson GPG Key fingerprint: 4801 0D71 49C0 1DD6 E5FD 6AC9 D757 2FE3 605E E6B0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHLBAEBCAA1FiEESAENcUnAHdbl/WrJ11cv42Be5rAFAmKfyDgXHGtqYXJ0YW5v bGlAb3V0bG9vay5jb20ACgkQ11cv42Be5rD4AgwAnHA0odJOwiH/ua1p65nJYyyl 2RacXEO98ulxegvWSxU3sL0ku28MkRANbYvPGqoHXts1ziUozZz/CftYNBGG4ems eDAQfrwXlDncFxRqwNaqY9uZLToKdEsJGM6bCGmZN1eGSU2InoAtTkh1aTWOfWDW PKLJAq7M/kfguXS+wP36rQuy1SiF3wbkEjEBbUlq1Z8kO/nJt56vbTKrbTIhAPYY Ppt0b+cwQV1PQbdbdvk2dkf5XwsFYlHJjWjU+7y4svTxpzisy2sq5LGEmgWTurVX oV1GueCc8X65DwYTw0YXaex/HKoAm+DW+TMur9dq6xGYs5fwi95TBXkgnYE//nj8 tA8mnt5Oze5HS/H7XdyYY+P9LcqWemXGcZ4oayF74P9mtDo2n1KTyYA8WyJbN5mH bQNHKkcVUndDuYSLt6i7oN8iBtjin/i3zJ65B/ORn9cnzK6y7nUEYAzOhX1fKmoZ x5NhT9gcFPERotW7tpWLvlTH+5HYLe2QJi6OrKZt =2CcG -----END PGP SIGNATURE----- --=-=-=--