From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 58168@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#58168: string-lessp glitches and inconsistencies
Date: Sat, 1 Oct 2022 15:37:25 +0200 [thread overview]
Message-ID: <E3917799-028F-46CF-BD7B-060CEEDE37BD@gmail.com> (raw)
In-Reply-To: <878rlzj1zv.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
1 okt. 2022 kl. 12.02 skrev Lars Ingebrigtsen <larsi@gnus.org>:
> Funnily enough, the latter displays in a different way for me, which may
> or may not be a bug:
>
> This is with `display-raw-bytes-as-hex' t.
You are right, that is completely broken -- display-raw-bytes-as-hex shouldn't affect the display of C1 controls.
Whether (string 128) displays "\200" or "\x80", however tarted up in a fancy face, it's still a lie. Only something like "\u0080" would actually be correct.
It seems to be a relic from the pre-Unicode days of Emacs: the code responsible muddles the display of raw bytes and unicode controls.
The attached patch untangles the two somewhat and lets display-raw-bytes-as-hex do what its name and documentation suggest, while using a non-confusing display for C1 controls.
The command
(insert "C1: " (string 128) " raw: " (unibyte-string 128) ".\n")
currently displays
C1: \200 raw: \200.
or
C1: \x80 raw: \x80.
depending on display-raw-bytes-as-hex. With the patch, we get
C1: \u0080 raw: \200.
or
C1: \u0080 raw: \x80.
which should satisfy everyone. What about it?
[-- Attachment #2: unicode-escape-display.diff --]
[-- Type: application/octet-stream, Size: 955 bytes --]
diff --git a/src/xdisp.c b/src/xdisp.c
index 55e74a3603..fa4fc2319e 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -8179,12 +8179,20 @@ get_next_display_element (struct it *it)
char str[10];
int len, i;
+ const char *format_string;
if (CHAR_BYTE8_P (c))
- /* Display \200 or \x80 instead of \17777600. */
- c = CHAR_TO_BYTE8 (c);
- const char *format_string = display_raw_bytes_as_hex
- ? "x%02x"
- : "%03o";
+ {
+ /* A raw byte: display using an octal or hex escape which
+ would produce this byte in a Lisp string literal. */
+ c = CHAR_TO_BYTE8 (c);
+ format_string = display_raw_bytes_as_hex ? "x%02x" : "%03o";
+ }
+ else
+ {
+ /* A Unicode character not displayed in any other way:
+ use a Unicode escape. */
+ format_string = c <= 0xffff ? "u%04X" : "U%08X";
+ }
len = sprintf (str, format_string, c + 0u);
XSETINT (it->ctl_chars[0], escape_glyph);
[-- Attachment #3: Type: text/plain, Size: 203 bytes --]
I see that the redisplay-testsuite.el needs amending too; it actually looks buggy in this respect. If the above approach is deemed acceptable, I'll submit a patch that includes that file as well.
next prev parent reply other threads:[~2022-10-01 13:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 16:24 bug#58168: string-lessp glitches and inconsistencies Mattias Engdegård
2022-09-29 17:00 ` Mattias Engdegård
2022-09-29 17:11 ` Eli Zaretskii
2022-09-30 20:04 ` Mattias Engdegård
2022-10-01 5:22 ` Eli Zaretskii
2022-10-01 19:57 ` Mattias Engdegård
2022-10-02 5:36 ` Eli Zaretskii
2022-10-03 19:48 ` Mattias Engdegård
2022-10-04 5:55 ` Eli Zaretskii
2022-10-04 17:40 ` Richard Stallman
2022-10-04 18:07 ` Eli Zaretskii
2022-10-06 9:05 ` Mattias Engdegård
2022-10-06 11:06 ` Eli Zaretskii
2022-10-07 14:23 ` Mattias Engdegård
2022-10-08 7:35 ` Eli Zaretskii
2022-10-14 14:39 ` Mattias Engdegård
2022-10-14 15:31 ` Eli Zaretskii
2022-10-17 12:44 ` Mattias Engdegård
2022-09-30 13:52 ` Lars Ingebrigtsen
2022-09-30 20:12 ` Mattias Engdegård
2022-10-01 5:34 ` Eli Zaretskii
2022-10-01 11:51 ` Mattias Engdegård
2022-10-01 10:02 ` Lars Ingebrigtsen
2022-10-01 10:12 ` Eli Zaretskii
2022-10-01 13:37 ` Mattias Engdegård [this message]
2022-10-01 13:43 ` Lars Ingebrigtsen
2022-10-03 19:48 ` Mattias Engdegård
2022-10-04 10:44 ` Lars Ingebrigtsen
2022-10-04 11:37 ` Eli Zaretskii
2022-10-04 14:44 ` Mattias Engdegård
2022-10-04 16:24 ` Eli Zaretskii
2022-10-06 9:05 ` Mattias Engdegård
2022-10-06 11:13 ` Eli Zaretskii
2022-10-06 12:43 ` Mattias Engdegård
2022-10-06 14:34 ` Eli Zaretskii
2022-10-07 14:45 ` Mattias Engdegård
2022-10-07 15:33 ` Eli Zaretskii
2022-10-08 17:13 ` Mattias Engdegård
2022-10-01 13:51 ` Eli Zaretskii
2022-10-01 5:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3917799-028F-46CF-BD7B-060CEEDE37BD@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=58168@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.