From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#58168: string-lessp glitches and inconsistencies Date: Sat, 1 Oct 2022 15:37:25 +0200 Message-ID: References: <7824372D-8002-4639-8AEE-E80A6D5FEFC6@gmail.com> <877d1l55rn.fsf@gnus.org> <469814C2-197A-4BCA-8E2A-245577340C1E@gmail.com> <878rlzj1zv.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_A3D1196E-9913-4565-A797-EED953C94F96" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36381"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58168@debbugs.gnu.org, Eli Zaretskii To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 01 15:38:45 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oechX-0009Hf-FP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Oct 2022 15:38:43 +0200 Original-Received: from localhost ([::1]:60864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oechW-0005Qu-B6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Oct 2022 09:38:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oecgt-0005OY-SK for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 09:38:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44915) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oecgs-0007KH-D0 for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 09:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oecgs-0005RN-81 for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 09:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Oct 2022 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58168 X-GNU-PR-Package: emacs Original-Received: via spool by 58168-submit@debbugs.gnu.org id=B58168.166463145520880 (code B ref 58168); Sat, 01 Oct 2022 13:38:02 +0000 Original-Received: (at 58168) by debbugs.gnu.org; 1 Oct 2022 13:37:35 +0000 Original-Received: from localhost ([127.0.0.1]:43993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oecgR-0005Qh-Bz for submit@debbugs.gnu.org; Sat, 01 Oct 2022 09:37:35 -0400 Original-Received: from mail-lf1-f49.google.com ([209.85.167.49]:33472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oecgP-0005QR-NJ for 58168@debbugs.gnu.org; Sat, 01 Oct 2022 09:37:34 -0400 Original-Received: by mail-lf1-f49.google.com with SMTP id d42so10781663lfv.0 for <58168@debbugs.gnu.org>; Sat, 01 Oct 2022 06:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date; bh=YxQy48H3j6v9FqLEl+lmYX7+PPFSt4w15rOI/aXZpq8=; b=RtWKn8np6mwM1p12Zsdo8UKPgNTFA8gYTffuTlwoNUF5GfINHkhFHVwSTS8j2PSSEs hesJTkzJ66bE/Io3+gdX8mZNQmhLFN++tOAnhVJFgrNcGvJJL1JNrDQWvYkdbbV2AbCp 20otuZmn6jgiNTB4O5rAM0wUG3z0Y2e9iIeRXdz4m8K8QKCadYt4RQ2xnBpnIqXRkz0w BOvas9c6xOxpK2gHrxyLMepkV3JTGD3mc72ihqiJ+DnGR9H7RbPm27ufZD2KF7T6SSa8 dkuVh0nHPpgEjgpO+s6fTyTcPwys/0bpGBP0DUA7DGnhCjk2wrAAIZTAaIc1kthQFJ3v L6hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date; bh=YxQy48H3j6v9FqLEl+lmYX7+PPFSt4w15rOI/aXZpq8=; b=UBA8YIC8BePtiLFUtDxPucSm3QbniPV9lu7Z3c3pNpPA1T6phUlqtuoDGubHseddAj r3yZX39XM1xE17wFWrDU/2cGLNzH6SuxsodPO2GzaeR2dtAPuEK6UkeNLxKuUBlD3g7z 7hhtQI72eW4Qhq7HU7edlNiDLzdbsWai1V9u7HLpvizW0OMX4OwhpQjr8NtJRGQuCQEq //VixaHLd3bGR71EPIsMdBvG1uppOHxfVuWZQvX4ZX2aJmW+j6T0pT39pbvxYkptZnsE mr5B9AEIHFCLVAaCnxypsWAj+nhVhrIjpE9MiF5AlveEkiTyDI7++6rc5uu1fezzMlp2 oUQA== X-Gm-Message-State: ACrzQf23QjPg31VUpTWW2d8I00UiJJ60AmUzFW8qELoz6IY4TP5zhXKc gqC0c4Ik828oWJCAgJNrcOY= X-Google-Smtp-Source: AMsMyM7gZP2+eo7ZWgCin+ax2uPRXStY4YJbmzmrRK2QhQSIYm2iWy0lFvuEVMK+R4tIivv772roxA== X-Received: by 2002:ac2:548a:0:b0:4a2:2b8f:7990 with SMTP id t10-20020ac2548a000000b004a22b8f7990mr423031lfk.402.1664631447464; Sat, 01 Oct 2022 06:37:27 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id z13-20020a056512308d00b00494a1b242dasm772427lfd.14.2022.10.01.06.37.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Oct 2022 06:37:26 -0700 (PDT) In-Reply-To: <878rlzj1zv.fsf@gnus.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244125 Archived-At: --Apple-Mail=_A3D1196E-9913-4565-A797-EED953C94F96 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 1 okt. 2022 kl. 12.02 skrev Lars Ingebrigtsen : > Funnily enough, the latter displays in a different way for me, which = may > or may not be a bug: >=20 > This is with `display-raw-bytes-as-hex' t. You are right, that is completely broken -- display-raw-bytes-as-hex = shouldn't affect the display of C1 controls. Whether (string 128) displays "\200" or "\x80", however tarted up in a = fancy face, it's still a lie. Only something like "\u0080" would = actually be correct. It seems to be a relic from the pre-Unicode days of Emacs: the code = responsible muddles the display of raw bytes and unicode controls. The attached patch untangles the two somewhat and lets = display-raw-bytes-as-hex do what its name and documentation suggest, = while using a non-confusing display for C1 controls. The command (insert "C1: " (string 128) " raw: " (unibyte-string 128) ".\n") currently displays C1: \200 raw: \200. or C1: \x80 raw: \x80. depending on display-raw-bytes-as-hex. With the patch, we get =C2=80 =C2=80 =C2=80C1: \u0080 raw: \200. or C1: \u0080 raw: \x80. which should satisfy everyone. What about it? --Apple-Mail=_A3D1196E-9913-4565-A797-EED953C94F96 Content-Disposition: attachment; filename=unicode-escape-display.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="unicode-escape-display.diff" Content-Transfer-Encoding: 7bit diff --git a/src/xdisp.c b/src/xdisp.c index 55e74a3603..fa4fc2319e 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -8179,12 +8179,20 @@ get_next_display_element (struct it *it) char str[10]; int len, i; + const char *format_string; if (CHAR_BYTE8_P (c)) - /* Display \200 or \x80 instead of \17777600. */ - c = CHAR_TO_BYTE8 (c); - const char *format_string = display_raw_bytes_as_hex - ? "x%02x" - : "%03o"; + { + /* A raw byte: display using an octal or hex escape which + would produce this byte in a Lisp string literal. */ + c = CHAR_TO_BYTE8 (c); + format_string = display_raw_bytes_as_hex ? "x%02x" : "%03o"; + } + else + { + /* A Unicode character not displayed in any other way: + use a Unicode escape. */ + format_string = c <= 0xffff ? "u%04X" : "U%08X"; + } len = sprintf (str, format_string, c + 0u); XSETINT (it->ctl_chars[0], escape_glyph); --Apple-Mail=_A3D1196E-9913-4565-A797-EED953C94F96 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii I see that the redisplay-testsuite.el needs amending too; it actually = looks buggy in this respect. If the above approach is deemed acceptable, = I'll submit a patch that includes that file as well. --Apple-Mail=_A3D1196E-9913-4565-A797-EED953C94F96--