From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 58168@debbugs.gnu.org, larsi@gnus.org
Subject: bug#58168: string-lessp glitches and inconsistencies
Date: Thu, 6 Oct 2022 14:43:09 +0200 [thread overview]
Message-ID: <4CFC3078-64FB-4EAC-A536-F6CBCEE2087D@gmail.com> (raw)
In-Reply-To: <83v8oxp5lk.fsf@gnu.org>
6 okt. 2022 kl. 13.13 skrev Eli Zaretskii <eliz@gnu.org>:
>> (format-message "%\345" 0)
>> => (error "Invalid format operation %å")
>
> And you want to show %\345 instead?
Maybe, or (as the patch suggested) using a different wording for raw bytes. In any case %å is clearly a lie since that character wasn't in the format string. What would you rather see in such a case?
> Are you sure this is not the
> consequence of inserting the error message into a multibyte buffer?
Quite sure. The error message is always produced as multibyte and the %c processing done at doprnt.c:471:
case 'c':
{
int chr = va_arg (ap, int);
tem = CHAR_STRING (chr, (unsigned char *) charbuf);
where CHAR_STRING renders chr (the %c argument passed to `error`) as a multibyte char to charbuf here.
>>> Who said anything about #x3fffc? The original code had #xfc, the
>>> unibyte code for #x3ffffc.
>>
>> There seems to be a misunderstanding. The original (and current) code attempts to display char #x3fffc, which is not a raw byte. It's just a typo for #x3ffffc -- not a big deal.
>
> But your change replaced it with \xfc, which is what I questioned.
Oh, I see -- you are looking at the hunk that changed the labels, not the character tested. When 3fffc was changed into 3ffffc, the "expected" string needed to change accordingly; for the latter, it's \xfc or \374 depending on mode.
> Why not test both #x3ffffc and #xfc? And the same question about
> \777777 vs \374.
Testing #x3ffffc inserts the raw byte #xfc so that takes care of that -- the test already exercised inserting the unibyte raw byte #x80 and the patch didn't change that.
I don't think these two cases actually exercise different paths in redisplay since the buffer is multibyte:
(insert "\xfc")
and
(insert (char-to-string #x3ffffc))
should have identical effects on the buffer and hence the display, but it doesn't hurt to have one of each.
\777774 is just octal for #x3fffc which was changed into the (intended) #x3ffffc, and \374 is octal for #xfc which is covered as above.
Thus, the only case actually removed was #x3fffc since it was a typo, and #x10abcd was put in its place.
next prev parent reply other threads:[~2022-10-06 12:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 16:24 bug#58168: string-lessp glitches and inconsistencies Mattias Engdegård
2022-09-29 17:00 ` Mattias Engdegård
2022-09-29 17:11 ` Eli Zaretskii
2022-09-30 20:04 ` Mattias Engdegård
2022-10-01 5:22 ` Eli Zaretskii
2022-10-01 19:57 ` Mattias Engdegård
2022-10-02 5:36 ` Eli Zaretskii
2022-10-03 19:48 ` Mattias Engdegård
2022-10-04 5:55 ` Eli Zaretskii
2022-10-04 17:40 ` Richard Stallman
2022-10-04 18:07 ` Eli Zaretskii
2022-10-06 9:05 ` Mattias Engdegård
2022-10-06 11:06 ` Eli Zaretskii
2022-10-07 14:23 ` Mattias Engdegård
2022-10-08 7:35 ` Eli Zaretskii
2022-10-14 14:39 ` Mattias Engdegård
2022-10-14 15:31 ` Eli Zaretskii
2022-10-17 12:44 ` Mattias Engdegård
2022-09-30 13:52 ` Lars Ingebrigtsen
2022-09-30 20:12 ` Mattias Engdegård
2022-10-01 5:34 ` Eli Zaretskii
2022-10-01 11:51 ` Mattias Engdegård
2022-10-01 10:02 ` Lars Ingebrigtsen
2022-10-01 10:12 ` Eli Zaretskii
2022-10-01 13:37 ` Mattias Engdegård
2022-10-01 13:43 ` Lars Ingebrigtsen
2022-10-03 19:48 ` Mattias Engdegård
2022-10-04 10:44 ` Lars Ingebrigtsen
2022-10-04 11:37 ` Eli Zaretskii
2022-10-04 14:44 ` Mattias Engdegård
2022-10-04 16:24 ` Eli Zaretskii
2022-10-06 9:05 ` Mattias Engdegård
2022-10-06 11:13 ` Eli Zaretskii
2022-10-06 12:43 ` Mattias Engdegård [this message]
2022-10-06 14:34 ` Eli Zaretskii
2022-10-07 14:45 ` Mattias Engdegård
2022-10-07 15:33 ` Eli Zaretskii
2022-10-08 17:13 ` Mattias Engdegård
2022-10-01 13:51 ` Eli Zaretskii
2022-10-01 5:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFC3078-64FB-4EAC-A536-F6CBCEE2087D@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=58168@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.