From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 58168@debbugs.gnu.org
Subject: bug#58168: string-lessp glitches and inconsistencies
Date: Fri, 14 Oct 2022 16:39:55 +0200 [thread overview]
Message-ID: <3C87B8E6-A52B-41B6-A959-954BBB5F788E@gmail.com> (raw)
In-Reply-To: <83lepqlqdy.fsf@gnu.org>
As performance is more acceptable now I'm not going to take any further action with respect of string<, but let me just answer your questions:
8 okt. 2022 kl. 09.35 skrev Eli Zaretskii <eliz@gnu.org>:
> I suggested to use memchr to find whether a string has any
> C0 or C1 bytes, _before_ doing the actual comparison, to find out
> whether a multibyte string includes any raw bytes, which would then
> require slower comparisons.
That isn't practical; we would traverse each argument in full, twice, even if there is a difference early on. While memchr is fast for what it does, it will still need to look at every bit of its input.
> I also suggested to try memmem as yet another possibility
There is no reason to believe that this would help in any way.
> This is me being happy.
Thank you, let's both rejoice then! Again, the improvements and analyses have been worthwhile.
next prev parent reply other threads:[~2022-10-14 14:39 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 16:24 bug#58168: string-lessp glitches and inconsistencies Mattias Engdegård
2022-09-29 17:00 ` Mattias Engdegård
2022-09-29 17:11 ` Eli Zaretskii
2022-09-30 20:04 ` Mattias Engdegård
2022-10-01 5:22 ` Eli Zaretskii
2022-10-01 19:57 ` Mattias Engdegård
2022-10-02 5:36 ` Eli Zaretskii
2022-10-03 19:48 ` Mattias Engdegård
2022-10-04 5:55 ` Eli Zaretskii
2022-10-04 17:40 ` Richard Stallman
2022-10-04 18:07 ` Eli Zaretskii
2022-10-06 9:05 ` Mattias Engdegård
2022-10-06 11:06 ` Eli Zaretskii
2022-10-07 14:23 ` Mattias Engdegård
2022-10-08 7:35 ` Eli Zaretskii
2022-10-14 14:39 ` Mattias Engdegård [this message]
2022-10-14 15:31 ` Eli Zaretskii
2022-10-17 12:44 ` Mattias Engdegård
2022-09-30 13:52 ` Lars Ingebrigtsen
2022-09-30 20:12 ` Mattias Engdegård
2022-10-01 5:34 ` Eli Zaretskii
2022-10-01 11:51 ` Mattias Engdegård
2022-10-01 10:02 ` Lars Ingebrigtsen
2022-10-01 10:12 ` Eli Zaretskii
2022-10-01 13:37 ` Mattias Engdegård
2022-10-01 13:43 ` Lars Ingebrigtsen
2022-10-03 19:48 ` Mattias Engdegård
2022-10-04 10:44 ` Lars Ingebrigtsen
2022-10-04 11:37 ` Eli Zaretskii
2022-10-04 14:44 ` Mattias Engdegård
2022-10-04 16:24 ` Eli Zaretskii
2022-10-06 9:05 ` Mattias Engdegård
2022-10-06 11:13 ` Eli Zaretskii
2022-10-06 12:43 ` Mattias Engdegård
2022-10-06 14:34 ` Eli Zaretskii
2022-10-07 14:45 ` Mattias Engdegård
2022-10-07 15:33 ` Eli Zaretskii
2022-10-08 17:13 ` Mattias Engdegård
2022-10-01 13:51 ` Eli Zaretskii
2022-10-01 5:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C87B8E6-A52B-41B6-A959-954BBB5F788E@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=58168@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.