From: Sam James <sam@gentoo.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Robert Pluim <rpluim@gmail.com>, luangruo@yahoo.com, emacs-devel@gnu.org
Subject: Re: HAVE_FAST_UNALIGNED_ACCESS
Date: Thu, 30 Mar 2023 12:09:41 +0100 [thread overview]
Message-ID: <87tty2ze7f.fsf@gentoo.org> (raw)
In-Reply-To: <83a5zu5ybx.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2483 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Po Lu <luangruo@yahoo.com>
>> Date: Thu, 30 Mar 2023 11:34:42 +0200
>>
>> Fstring_lessp has:
>>
>> /* Check whether the platform allows access to unaligned addresses for
>> size_t integers without trapping or undue penalty (a few cycles is OK).
>>
>> This whitelist is incomplete but since it is only used to improve
>> performance, omitting cases is safe. */
>> #if defined __x86_64__|| defined __amd64__ \
>> || defined __i386__ || defined __i386 \
>> || defined __arm64__ || defined __aarch64__ \
>> || defined __powerpc__ || defined __powerpc \
>> || defined __ppc__ || defined __ppc \
>> || defined __s390__ || defined __s390x__
>> #define HAVE_FAST_UNALIGNED_ACCESS 1
>> #else
>> #define HAVE_FAST_UNALIGNED_ACCESS 0
>> #endif
>>
>> but even if unaligned access is normally permitted by a machine, it is
>> still undefined behavior to dereference an unaligned pointer.
>
> This is incorrect. There's nothing undefined about x86 unaligned
> accesses. C standards can regard this as UB, but we are using
> machine-specific knowledge here (and Emacs cannot be built with a
> strict adherence to C standards anyway).
Things can still go wrong on x86, particularly with SIMD:
https://pzemtsov.github.io/2016/11/06/bug-story-alignment-on-x86.html.
>
>> Instead, HAVE_FAST_UNALIGNED_ACCESS and UNALIGNED_LOAD_SIZE should be
>> removed and memcpy used instead:
>>
>> word_t a, c;
>>
>> memcpy (&a, w1 + b / ws, sizeof a);
>> memcpy (&c, w2 + b / ws, sizeof c);
>>
>> doing so will make the compiler itself generate the right sequence of
>> instructions for performing unaligned accesses, normally with only a few
>> cycles penalty.
>
> We don't want that penalty here, that's all.
>
>> I would like to install such a change on emacs-29.
>
> No, please don't.
>
>> Emacs currently crashes when built with various compilers performing
>> pointer alignment checks.
>
> Details, please. Which compilers, on what platforms, for what target
> architectures, etc. Unconditionally removing the fast copy there is a
> non-starter.
I imagine they're referring to UBSAN. Emacs may want to add an
annotation where HAVE_FAST_UNALIGNED_ACCESS is used.
But for modern compilers, they will indeed DTRT anyway when they
see memcpy.
See https://github.com/WayneD/rsync/pull/428 for an example.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]
next prev parent reply other threads:[~2023-03-30 11:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 9:34 HAVE_FAST_UNALIGNED_ACCESS Robert Pluim
2023-03-30 10:26 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-03-30 11:09 ` Sam James [this message]
2023-03-30 12:18 ` HAVE_FAST_UNALIGNED_ACCESS Arsen Arsenović
[not found] ` <87v8ihu3t8.fsf@yahoo.com>
2023-03-31 7:15 ` HAVE_FAST_UNALIGNED_ACCESS Robert Pluim
2023-03-31 7:45 ` HAVE_FAST_UNALIGNED_ACCESS Arsen Arsenović
2023-03-31 17:29 ` HAVE_FAST_UNALIGNED_ACCESS Mattias Engdegård
2023-03-31 20:13 ` HAVE_FAST_UNALIGNED_ACCESS Arsen Arsenović
2023-03-30 10:28 ` HAVE_FAST_UNALIGNED_ACCESS Mattias Engdegård
2023-03-30 11:38 ` HAVE_FAST_UNALIGNED_ACCESS Vibhav Pant
2023-03-31 16:57 ` HAVE_FAST_UNALIGNED_ACCESS Mattias Engdegård
2023-03-31 17:59 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-03-31 18:03 ` HAVE_FAST_UNALIGNED_ACCESS Mattias Engdegård
2023-03-31 18:12 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 0:45 ` HAVE_FAST_UNALIGNED_ACCESS Po Lu
2023-04-01 5:43 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 6:31 ` HAVE_FAST_UNALIGNED_ACCESS Po Lu
2023-04-01 6:39 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 7:42 ` HAVE_FAST_UNALIGNED_ACCESS Mattias Engdegård
2023-04-01 8:19 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 9:17 ` HAVE_FAST_UNALIGNED_ACCESS Po Lu
2023-04-01 11:25 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 12:59 ` HAVE_FAST_UNALIGNED_ACCESS Arsen Arsenović
2023-04-01 13:33 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 15:22 ` HAVE_FAST_UNALIGNED_ACCESS Arsen Arsenović
2023-04-01 16:22 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-02 0:50 ` HAVE_FAST_UNALIGNED_ACCESS Po Lu
2023-04-02 0:48 ` HAVE_FAST_UNALIGNED_ACCESS Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tty2ze7f.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.