From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Arsen Arsenović" <arsen@aarsen.me>,
mattias.engdegard@gmail.com, vibhavp@gmail.com, rpluim@gmail.com,
emacs-devel@gnu.org
Subject: Re: HAVE_FAST_UNALIGNED_ACCESS
Date: Sun, 02 Apr 2023 08:48:02 +0800 [thread overview]
Message-ID: <87ilefrtx9.fsf@yahoo.com> (raw)
In-Reply-To: <83zg7rybfo.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 01 Apr 2023 16:33:15 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Arsen Arsenović <arsen@aarsen.me>
>> Cc: Po Lu <luangruo@yahoo.com>, mattias.engdegard@gmail.com,
>> vibhavp@gmail.com, rpluim@gmail.com, emacs-devel@gnu.org
>> Date: Sat, 01 Apr 2023 14:59:53 +0200
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > I'm still unconvinced, and I said already what will have a chance of
>> > convincing me: a specific report about a problem this particular code
>> > causes on a specific existing platform we support in Emacs 29 and with
>> > a specific compiler.
>>
>> Similar (but not exactly the same) loops as this one have been shown to
>> generate incorrect code in this thread. It's not a large leap for it to
>> happen to this one, introducing subtle errors for a bit of code that is
>> completely unnecessary (as demonstrated by it being optional),
>> especially at higher optimization levels, where the compiler could
>> easily produce better code than the assumption of a 'mov' would.
>>
>> Is the following trivial enough for 29?
>
> You are again trying to push for a change without showing any actual
> bug with the existing code. Please humor me, and please show me an
> actual bug due to the existing code before suggesting a solution. See
> above for the description of the details I'd like to know about such
> actual bug.
> Sorry, I don't want to risk any errors, and I would like to avoid any
> experiments with the release branch. Which is why I'm asking for hard
> evidence. It isn't that I don't understand what you and others are
> saying, or don't believe you. It's just that we need to see the
> problems before we can judge the solutions that must be safe on this
> branch.
The nature of this bug is that there is no ``hard evidence'' of its
presence, until it strikes. Just like writing outside malloc'ed memory,
or freeing a pointer twice, or signed integer overflow (which falls
apart entirely on the R4000.)
This code has a very high risk for errors.
Removing it entirely will reduce the risk, since it was only installed
late in Emacs 29's development.
prev parent reply other threads:[~2023-04-02 0:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 9:34 HAVE_FAST_UNALIGNED_ACCESS Robert Pluim
2023-03-30 10:26 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-03-30 11:09 ` HAVE_FAST_UNALIGNED_ACCESS Sam James
2023-03-30 12:18 ` HAVE_FAST_UNALIGNED_ACCESS Arsen Arsenović
[not found] ` <87v8ihu3t8.fsf@yahoo.com>
2023-03-31 7:15 ` HAVE_FAST_UNALIGNED_ACCESS Robert Pluim
2023-03-31 7:45 ` HAVE_FAST_UNALIGNED_ACCESS Arsen Arsenović
2023-03-31 17:29 ` HAVE_FAST_UNALIGNED_ACCESS Mattias Engdegård
2023-03-31 20:13 ` HAVE_FAST_UNALIGNED_ACCESS Arsen Arsenović
2023-03-30 10:28 ` HAVE_FAST_UNALIGNED_ACCESS Mattias Engdegård
2023-03-30 11:38 ` HAVE_FAST_UNALIGNED_ACCESS Vibhav Pant
2023-03-31 16:57 ` HAVE_FAST_UNALIGNED_ACCESS Mattias Engdegård
2023-03-31 17:59 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-03-31 18:03 ` HAVE_FAST_UNALIGNED_ACCESS Mattias Engdegård
2023-03-31 18:12 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 0:45 ` HAVE_FAST_UNALIGNED_ACCESS Po Lu
2023-04-01 5:43 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 6:31 ` HAVE_FAST_UNALIGNED_ACCESS Po Lu
2023-04-01 6:39 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 7:42 ` HAVE_FAST_UNALIGNED_ACCESS Mattias Engdegård
2023-04-01 8:19 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 9:17 ` HAVE_FAST_UNALIGNED_ACCESS Po Lu
2023-04-01 11:25 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 12:59 ` HAVE_FAST_UNALIGNED_ACCESS Arsen Arsenović
2023-04-01 13:33 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-01 15:22 ` HAVE_FAST_UNALIGNED_ACCESS Arsen Arsenović
2023-04-01 16:22 ` HAVE_FAST_UNALIGNED_ACCESS Eli Zaretskii
2023-04-02 0:50 ` HAVE_FAST_UNALIGNED_ACCESS Po Lu
2023-04-02 0:48 ` Po Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilefrtx9.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=arsen@aarsen.me \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=rpluim@gmail.com \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.