From: "João Távora" <joaotavora@gmail.com>
To: Payas Relekar <relekarpayas@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Progress on merging Eglot?
Date: Mon, 19 Sep 2022 15:09:59 +0100 [thread overview]
Message-ID: <87sfkn4frc.fsf@gmail.com> (raw)
In-Reply-To: <CAB6f120YUxp_jSMz=j=OytN5Ucki1mRUE0mCB9HYygX4RsgR-w@mail.gmail.com> (Payas Relekar's message of "Mon, 19 Sep 2022 14:47:42 +0530")
Payas Relekar <relekarpayas@gmail.com> writes:
> Alright! I think we have everything we need. I took the append URLs to
> bottom of commit message approach. Here's what we have:
>
> - History visible for file lisp/progmodes/eglot.el
> - Commit message length undisturbed
> - every #num is appended with appropriate URL at the bottom of commit
> message
>
> These are the latest and (hopefully) final URLs:
>
> Code:
> https://gist.github.com/bhankas/422c34db2e987d4dc3f243e26ba156a3
>
> (Please ensure eglot2emacs.py is in same directory as eglot/ and emacs/
> repos)
>
> Emacs repo with eglot.el merged:
> https://github.com/bhankas/emacs
>
> eglot.el file history within merged emacs repo:
> https://github.com/bhankas/emacs/commits/master/lisp/progmodes/eglot.el
>
> If all is good, that concludes #2 on João's list.
>
> Let me know for any corrections and/or improvements.
Thanks very much Payas, your work provided a most excellent start.
I took your GitHub gist, forked it, and reworked it. That version now
lives at
https://gist.github.com/joaotavora/2ed97f2ec85958986983d5cb78202770
and I ask that any work proceeds from there.
Most of my work happened in the eglot2emacs.py script, which I have
renamed eglot2emacs-message-callback.py. After many tweaks, I ran it
through git filter-repo and think this version is now my preferred one.
For instance it transforms:
Close #974, #776: Update docstring of eglot-events-buffer-size
* eglot.el (eglot-events-buffer-size): Mention that you need to<CARRIAGE-RETURN>
restart the connection for 'eglot-events-buffer-size' to take effect.
into
Update docstring of eglot-events-buffer-size
* eglot.el (eglot-events-buffer-size): Mention that you need to
restart the connection for 'eglot-events-buffer-size' to take effect.
GitHub-reference: Close https://github.com/joaotavora/eglot/issues/974
GitHub-reference: Close https://github.com/joaotavora/eglot/issues/776
It also does other small tricks (and maybe some more can be added)
The only problem is that I can't get run the full eglot2emacs.sh to run.
The process is blocked, I think, by an Emacs commit hook that refuses to
accept some trailing changes in some unrelated files. Can you see
what's up with that? Did I mess up eglot2emacs.sh?
João
next prev parent reply other threads:[~2022-09-19 14:09 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 16:48 Progress on merging Eglot? Payas Relekar
2022-09-08 17:09 ` João Távora
2022-09-08 17:09 ` Payas Relekar
2022-09-08 17:16 ` João Távora
2022-09-08 17:26 ` Payas Relekar
2022-09-18 16:31 ` Payas Relekar
2022-09-18 20:30 ` Philip Kaludercic
2022-09-18 20:47 ` Dmitry Gutov
2022-09-18 21:00 ` Philip Kaludercic
2022-09-18 21:11 ` Dmitry Gutov
2022-09-18 21:13 ` João Távora
2022-09-18 21:12 ` João Távora
2022-09-18 21:20 ` Philip Kaludercic
2022-09-18 21:24 ` João Távora
2022-09-19 2:37 ` Stefan Monnier
2022-09-19 4:25 ` Payas Relekar
2022-09-19 4:42 ` Payas Relekar
2022-09-19 7:23 ` João Távora
2022-09-19 9:09 ` Payas Relekar
2022-09-19 9:25 ` Payas Relekar
2022-09-19 9:17 ` Payas Relekar
2022-09-19 14:09 ` João Távora [this message]
2022-09-23 15:23 ` Progress on merging Eglot: update João Távora
2022-09-24 4:32 ` Payas Relekar
2022-09-24 7:05 ` Payas Relekar
2022-09-25 2:46 ` Richard Stallman
2022-09-25 3:04 ` Payas Relekar
2022-09-25 5:04 ` Eli Zaretskii
2022-09-26 12:10 ` Richard Stallman
2022-09-26 12:13 ` João Távora
2022-09-27 16:16 ` Richard Stallman
2022-09-19 12:25 ` Progress on merging Eglot? Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2022-09-19 16:32 Payas Relekar
2022-09-19 16:59 ` João Távora
2022-09-19 15:12 Payas Relekar
2022-09-19 16:09 ` João Távora
2022-09-19 13:11 Payas Relekar
2022-09-19 14:28 ` João Távora
2022-09-19 15:50 ` Payas Relekar
2022-09-18 16:55 Payas Relekar
2022-09-08 12:31 Payas Relekar
2022-09-08 13:09 ` João Távora
2022-09-08 13:55 ` Philip Kaludercic
2022-09-08 14:02 ` João Távora
2022-09-08 14:14 ` Philip Kaludercic
2022-09-08 14:24 ` Payas Relekar
2022-09-08 14:44 ` Philip Kaludercic
2022-09-08 14:47 ` João Távora
2022-09-08 14:54 ` Payas Relekar
[not found] ` <CALDnm50tiazUMnm9D3knBUCSLbT4FLvSPoX4ayUEmOtQSHbCtw@mail.gmail.com>
[not found] ` <87r10lor2c.fsf@gmail.com>
2022-09-08 16:08 ` João Távora
2022-09-08 14:26 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfkn4frc.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=relekarpayas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.