From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Progress on merging Eglot? Date: Mon, 19 Sep 2022 15:09:59 +0100 Message-ID: <87sfkn4frc.fsf@gmail.com> References: <8735d1ajxb.fsf@gmail.com> <874jxhaizf.fsf@gmail.com> <87zgf993py.fsf@gmail.com> <87fsgod4ee.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14297"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Monnier , emacs-devel To: Payas Relekar Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 19 16:11:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaHUO-0003W0-Q6 for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 16:11:12 +0200 Original-Received: from localhost ([::1]:49246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaHUN-0003Nd-7j for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 10:11:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaHS9-0002cD-WE for emacs-devel@gnu.org; Mon, 19 Sep 2022 10:08:54 -0400 Original-Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:34625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaHS8-00070y-7n for emacs-devel@gnu.org; Mon, 19 Sep 2022 10:08:53 -0400 Original-Received: by mail-wr1-x433.google.com with SMTP id z6so15229166wrq.1 for ; Mon, 19 Sep 2022 07:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=M3U3pCmOclHEtkFWDwEHzJ79bQ+ncykXyBKRihu23oQ=; b=Acdu/LApCo3B6lx5an5aGHlUzgGuCpOW6YZu/sKdVi374PGVbeeRfsEZraj5Hoi8af XbvoMnAFh5e6x71tB5pU4LedItGlggN9x34lFQuIf2c9AE6H17lyzvhTSHMROVXKj9Dg mtE2pOfOIJ59F2u5uG+VIXsbu+yaBnZM9O4lLJrh/3kXaJ7nLlx5eBVrSzLeYD0/UNyc IW/kxGb4ocCUENPx//E5lBCceYk/O5bjvfT0MA4Wxa0F5h9hulN6xKeGuUcbCCaAHquQ 6GGXzBvTA/fHsezXKWxxIWIPlMabjKHdhen+ESOOO7EmlzYad1OmQkOou5xswpEdBxun o4Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=M3U3pCmOclHEtkFWDwEHzJ79bQ+ncykXyBKRihu23oQ=; b=zfxXohxAhb1/9thEamG1UEWBp8qgKDi4v3djipWfIW4Vck8yc5NhFfagW9z2/kFu3T +IfmwPu2XT/zSbHmi+nww+41dUGb356un9FsVNduW1pxc7riRI7kw1v98NWhvqvc6wYH fv5VAeli1T3Gf4bi2R/3qhoWl9JhmYwfIPq8tX9O0aPNGRsjNBWu4yci+SsmXX3JGPXG FJD2m7p1fBxFP5eif/4MAFezGULE6SJHLIZT6JHMbULImwuakzqSvXR0/x2lAImJ89bI oBrxsDp66WD8rhR0u8s7RVp1uagDd4PYafpahzlhSVPluiE0uQxezdjAP80AhYbq1smb YNww== X-Gm-Message-State: ACrzQf0pASF8RR1u+Eyu6U5k/68fNvPj/RVp7kCmnpDzNTWhYInDNsOP DK0A+f4p6XNPOp4qljp5f63PrsvpEKY= X-Google-Smtp-Source: AMsMyM4Exx+o2nKzFtFqT1wjaqnx+0FVeJE0ErJikmJPNsj8fByvYBQVWEyieTZd3VhA/kr+jvH2Mg== X-Received: by 2002:a5d:678a:0:b0:22a:c9d9:443d with SMTP id v10-20020a5d678a000000b0022ac9d9443dmr10364033wru.129.1663596529735; Mon, 19 Sep 2022 07:08:49 -0700 (PDT) Original-Received: from krug ([87.196.73.224]) by smtp.gmail.com with ESMTPSA id n1-20020a1c2701000000b003b3307fb98fsm14318446wmn.24.2022.09.19.07.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 07:08:49 -0700 (PDT) In-Reply-To: (Payas Relekar's message of "Mon, 19 Sep 2022 14:47:42 +0530") Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295703 Archived-At: Payas Relekar writes: > Alright! I think we have everything we need. I took the append URLs to > bottom of commit message approach. Here's what we have: > > - History visible for file lisp/progmodes/eglot.el > - Commit message length undisturbed > - every #num is appended with appropriate URL at the bottom of commit > message > > These are the latest and (hopefully) final URLs: > > Code: > https://gist.github.com/bhankas/422c34db2e987d4dc3f243e26ba156a3 > > (Please ensure eglot2emacs.py is in same directory as eglot/ and emacs/ > repos) > > Emacs repo with eglot.el merged: > https://github.com/bhankas/emacs > > eglot.el file history within merged emacs repo: > https://github.com/bhankas/emacs/commits/master/lisp/progmodes/eglot.el > > If all is good, that concludes #2 on Jo=C3=A3o's list. > > Let me know for any corrections and/or improvements. Thanks very much Payas, your work provided a most excellent start. I took your GitHub gist, forked it, and reworked it. That version now lives at https://gist.github.com/joaotavora/2ed97f2ec85958986983d5cb78202770 and I ask that any work proceeds from there. Most of my work happened in the eglot2emacs.py script, which I have renamed eglot2emacs-message-callback.py. After many tweaks, I ran it through git filter-repo and think this version is now my preferred one. For instance it transforms: Close #974, #776: Update docstring of eglot-events-buffer-size =20=20=20=20 * eglot.el (eglot-events-buffer-size): Mention that you need to restart the connection for 'eglot-events-buffer-size' to take effect. into Update docstring of eglot-events-buffer-size * eglot.el (eglot-events-buffer-size): Mention that you need to restart the connection for 'eglot-events-buffer-size' to take effect. =20=20=20=20 GitHub-reference: Close https://github.com/joaotavora/eglot/issues/974 GitHub-reference: Close https://github.com/joaotavora/eglot/issues/776 It also does other small tricks (and maybe some more can be added) The only problem is that I can't get run the full eglot2emacs.sh to run. The process is blocked, I think, by an Emacs commit hook that refuses to accept some trailing changes in some unrelated files. Can you see what's up with that? Did I mess up eglot2emacs.sh? Jo=C3=A3o