From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stefankangas@gmail.com, larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode
Date: Mon, 31 Oct 2022 16:42:57 +0100 [thread overview]
Message-ID: <87sfj4ngn2.fsf@gmail.com> (raw)
In-Reply-To: <83o7tsdncd.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 31 Oct 2022 17:28:18 +0200")
>>>>> On Mon, 31 Oct 2022 17:28:18 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> make[3]: Entering directory '/home/rpluim/repos/emacs/lispʼ
>> ELC winner.elc
>>
>> In toplevel form:
>> winner.el:314:15: Warning: Invalid ‘kbd’ syntax: "[left]"
>>
>> Eli? Lars? Is this overkill for such a rare case?
Eli> I don't know. I guess it depends on how many people will be tripped
Eli> by this. The change itself is small enough, I think.
0, it turns out, as thereʼs already a runtime check for this case 😀
Motto: test the existing code before proposing changes
Robert
--
next prev parent reply other threads:[~2022-10-31 15:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 15:01 bug#58799: Make winner key sequences repeatable in repeat-mode Damien Cassou
2022-10-26 19:52 ` Stefan Kangas
2022-10-27 9:04 ` Robert Pluim
2022-10-27 10:58 ` Stefan Kangas
2022-10-27 11:39 ` Robert Pluim
2022-10-27 12:31 ` Stefan Kangas
2022-10-27 13:38 ` Robert Pluim
2022-10-27 16:10 ` Stefan Kangas
2022-10-27 16:18 ` Robert Pluim
2022-10-27 16:33 ` Robert Pluim
2022-10-28 9:36 ` Robert Pluim
2022-10-28 15:41 ` Stefan Kangas
2022-10-31 14:25 ` Robert Pluim
2022-10-31 14:47 ` Stefan Kangas
2022-10-31 15:09 ` Robert Pluim
2022-10-31 15:28 ` Eli Zaretskii
2022-10-31 15:42 ` Robert Pluim [this message]
2022-10-30 6:39 ` Damien Cassou
2022-10-30 12:38 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfj4ngn2.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.