From: Robert Pluim <rpluim@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Damien Cassou <damien@cassou.me>,
Lars Ingebrigtsen <larsi@gnus.org>,
58799@debbugs.gnu.org
Subject: bug#58799: Make winner key sequences repeatable in repeat-mode
Date: Thu, 27 Oct 2022 15:38:17 +0200 [thread overview]
Message-ID: <87lep1tmie.fsf@gmail.com> (raw)
In-Reply-To: <CADwFkmk63iJ-eg0xLKGSo3s_pMQNk7BxoaMS1xfrO9ez8+Cn1w@mail.gmail.com> (Stefan Kangas's message of "Thu, 27 Oct 2022 05:31:21 -0700")
>>>>> On Thu, 27 Oct 2022 05:31:21 -0700, Stefan Kangas <stefankangas@gmail.com> said:
Stefan> Robert Pluim <rpluim@gmail.com> writes:
>> (defvar-keymap winner-repeat-map
>> :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'."
>> <left> #'winner-undo
>> <right> #'winner-redo)
>>
>> (but you can stick them in a .el file)
Stefan> Hmm, right. I think that's a bug though, because when loading such a
Stefan> .elc file I get:
Stefan> keymap--check: [left] is not a valid key definition; see ‘key-valid-p’
Stefan> So we should probably make sure that the `defvar-keymap' macro errors
Stefan> out.
Thatʼs easy enough (putting it in `define-keymap' would bring out the
backwards-compatibility police, I think). Probably needs an update to
the `defvar-keymap' docstring as well.
Robert
--
diff --git a/lisp/keymap.el b/lisp/keymap.el
index 107565590c..73a9e657fe 100644
--- a/lisp/keymap.el
+++ b/lisp/keymap.el
@@ -581,6 +581,10 @@ defvar-keymap
(setq key (pop defs))
(pop defs)
(when (not (eq key :menu))
+ (when (not (key-valid-p key))
+ (error
+ "Invalid key '%s' in keymap '%s' (see `key-valid-p')"
+ key variable-name))
(if (member key seen-keys)
(error "Duplicate definition for key '%s' in keymap '%s'"
key variable-name)
next prev parent reply other threads:[~2022-10-27 13:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 15:01 bug#58799: Make winner key sequences repeatable in repeat-mode Damien Cassou
2022-10-26 19:52 ` Stefan Kangas
2022-10-27 9:04 ` Robert Pluim
2022-10-27 10:58 ` Stefan Kangas
2022-10-27 11:39 ` Robert Pluim
2022-10-27 12:31 ` Stefan Kangas
2022-10-27 13:38 ` Robert Pluim [this message]
2022-10-27 16:10 ` Stefan Kangas
2022-10-27 16:18 ` Robert Pluim
2022-10-27 16:33 ` Robert Pluim
2022-10-28 9:36 ` Robert Pluim
2022-10-28 15:41 ` Stefan Kangas
2022-10-31 14:25 ` Robert Pluim
2022-10-31 14:47 ` Stefan Kangas
2022-10-31 15:09 ` Robert Pluim
2022-10-31 15:28 ` Eli Zaretskii
2022-10-31 15:42 ` Robert Pluim
2022-10-30 6:39 ` Damien Cassou
2022-10-30 12:38 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lep1tmie.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=58799@debbugs.gnu.org \
--cc=damien@cassou.me \
--cc=larsi@gnus.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.