From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: stefankangas@gmail.com, larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode
Date: Mon, 31 Oct 2022 17:28:18 +0200 [thread overview]
Message-ID: <83o7tsdncd.fsf@gnu.org> (raw)
In-Reply-To: <87wn8gni65.fsf@gmail.com> (message from Robert Pluim on Mon, 31 Oct 2022 16:09:54 +0100)
> From: Robert Pluim <rpluim@gmail.com>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
> Date: Mon, 31 Oct 2022 16:09:54 +0100
>
> diff --git c/lisp/keymap.el i/lisp/keymap.el
> index 107565590c..750095fab4 100644
> --- c/lisp/keymap.el
> +++ i/lisp/keymap.el
> @@ -545,6 +545,10 @@ define-keymap
> (let ((def (pop definitions)))
> (if (eq key :menu)
> (easy-menu-define nil keymap "" def)
> + (unless (key-valid-p key)
> + (error
> + "Key '%s' in keymap '%s' is not `key-valid-p'"
> + key keymap))
> (if (member key seen-keys)
> (error "Duplicate definition for key: %S %s" key keymap)
> (push key seen-keys))
>
> which will give a run-time error for things like "[left]" and
> '[left]', but thatʼs redundant with the compile time warning:
>
> make[3]: Entering directory '/home/rpluim/repos/emacs/lispʼ
> ELC winner.elc
>
> In toplevel form:
> winner.el:314:15: Warning: Invalid ‘kbd’ syntax: "[left]"
>
> Eli? Lars? Is this overkill for such a rare case?
I don't know. I guess it depends on how many people will be tripped
by this. The change itself is small enough, I think.
next prev parent reply other threads:[~2022-10-31 15:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 15:01 bug#58799: Make winner key sequences repeatable in repeat-mode Damien Cassou
2022-10-26 19:52 ` Stefan Kangas
2022-10-27 9:04 ` Robert Pluim
2022-10-27 10:58 ` Stefan Kangas
2022-10-27 11:39 ` Robert Pluim
2022-10-27 12:31 ` Stefan Kangas
2022-10-27 13:38 ` Robert Pluim
2022-10-27 16:10 ` Stefan Kangas
2022-10-27 16:18 ` Robert Pluim
2022-10-27 16:33 ` Robert Pluim
2022-10-28 9:36 ` Robert Pluim
2022-10-28 15:41 ` Stefan Kangas
2022-10-31 14:25 ` Robert Pluim
2022-10-31 14:47 ` Stefan Kangas
2022-10-31 15:09 ` Robert Pluim
2022-10-31 15:28 ` Eli Zaretskii [this message]
2022-10-31 15:42 ` Robert Pluim
2022-10-30 6:39 ` Damien Cassou
2022-10-30 12:38 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o7tsdncd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=rpluim@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.