From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#58799: Make winner key sequences repeatable in repeat-mode Date: Thu, 27 Oct 2022 15:38:17 +0200 Message-ID: <87lep1tmie.fsf@gmail.com> References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10687"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 27 15:39:59 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo371-0002Xu-8z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Oct 2022 15:39:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo367-0007G7-KP; Thu, 27 Oct 2022 09:39:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo366-0007BM-8x for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 09:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo366-0001Wz-0l for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 09:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo365-0002ws-RL for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 09:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58799-submit@debbugs.gnu.org id=B58799.166687790711291 (code B ref 58799); Thu, 27 Oct 2022 13:39:01 +0000 Original-Received: (at 58799) by debbugs.gnu.org; 27 Oct 2022 13:38:27 +0000 Original-Received: from localhost ([127.0.0.1]:56519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo35W-0002w2-Ob for submit@debbugs.gnu.org; Thu, 27 Oct 2022 09:38:27 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:36854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo35V-0002vq-Bf for 58799@debbugs.gnu.org; Thu, 27 Oct 2022 09:38:25 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id j15so2236108wrq.3 for <58799@debbugs.gnu.org>; Thu, 27 Oct 2022 06:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0WyG8b/pFfJCSEKUF/1AO/MRDEzOQLfxoU/Wr8jDgwg=; b=n97cV56dFA2/tO2C/lpUMN+6xK8c3fkpDPEhTR/TfrovudLDTqQKgDckybn7jER1nb 4gLAi+Cvb8kBdWmzoxvkOEiHeeTfd4VpcAbxfRcAkHdcwOJMdDGa8izlAnEWPsSKDoDj wZwPliHIMD3jmIeKLb1uqLEkBwZ11BiW10q0qSI4DWvowslAstHFZz8+GRWIKB6iPA43 QpuLBS30t6KQQQQX8RwaYiLWqADctQ6JdSt/AC4QcqXERW4zbAugoUAS9GFBeLWrYJo7 cEnCQzPovZX0n/oRMPE45v0DXlXqp1CY4s9QD4Ul5bmeOGdJTfJ/B4I9m2l10c2/NIeM M2yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0WyG8b/pFfJCSEKUF/1AO/MRDEzOQLfxoU/Wr8jDgwg=; b=VcQN2MX+DmTUnzvR9GtAKHPr9SH4L+gyy4QvuB7+HFdCaAhQm0csUxToKzxgIBr1wX pTyRrrpYADnLc+M/tDeIhI26x37VZgVVEl9WsfmMEmrOBhDjPn9HOfeyeJTM2xO9NcR5 NILtYC/QSeA+7NmgnGdVdcNvwRYNxT/uogbnHHlnpwO0KZtwlqaum0Z3GWK650gConHG XVVVV/RZCZxg7uew3cQy1MfVbAjN1pAxg0kWm2aldvjD1qo0hXCQOh1cO9G/UTo2K1O2 Zjws9zdjX3plIbjwiHjtCT0BxnmHZWSk64lK+kjcZQRol5eIs6N2vqAi1ZTMITf7VLXN We+w== X-Gm-Message-State: ACrzQf0jc0iy/DDsK+yTzbA+vxWt8mYmngI892gDWSgR+pTqwOnxaVOf 8WAuzna5lHVX5k3mLptpx110dgcZ2lQ= X-Google-Smtp-Source: AMsMyM6qYZUT7AhrPLxSKIwyCtkVWko0jlqV9Xss+Z/yllPS+Ca3tOT8dN27Jw92zSdnRd/M+pRLpQ== X-Received: by 2002:a05:6000:1866:b0:236:715a:16c1 with SMTP id d6-20020a056000186600b00236715a16c1mr13945134wri.537.1666877898919; Thu, 27 Oct 2022 06:38:18 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id u3-20020adfdd43000000b002364c77bc96sm1232133wrm.33.2022.10.27.06.38.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 06:38:18 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Thu, 27 Oct 2022 05:31:21 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246303 Archived-At: >>>>> On Thu, 27 Oct 2022 05:31:21 -0700, Stefan Kangas said: Stefan> Robert Pluim writes: >> (defvar-keymap winner-repeat-map >> :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." >> #'winner-undo >> #'winner-redo) >>=20 >> (but you can stick them in a .el file) Stefan> Hmm, right. I think that's a bug though, because when loading = such a Stefan> .elc file I get: Stefan> keymap--check: [left] is not a valid key definition; see =E2=80= =98key-valid-p=E2=80=99 Stefan> So we should probably make sure that the `defvar-keymap' macro = errors Stefan> out. That=CA=BCs easy enough (putting it in `define-keymap' would bring out the backwards-compatibility police, I think). Probably needs an update to the `defvar-keymap' docstring as well. Robert --=20 diff --git a/lisp/keymap.el b/lisp/keymap.el index 107565590c..73a9e657fe 100644 --- a/lisp/keymap.el +++ b/lisp/keymap.el @@ -581,6 +581,10 @@ defvar-keymap (setq key (pop defs)) (pop defs) (when (not (eq key :menu)) + (when (not (key-valid-p key)) + (error + "Invalid key '%s' in keymap '%s' (see `key-valid-p')" + key variable-name)) (if (member key seen-keys) (error "Duplicate definition for key '%s' in keymap '%s'" key variable-name)