From: Michael Albinus <michael.albinus@gmx.de>
To: "João Távora" <joaotavora@gmail.com>
Cc: 62694@debbugs.gnu.org
Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp
Date: Thu, 06 Apr 2023 16:58:44 +0200 [thread overview]
Message-ID: <87ile9t5uj.fsf@gmx.de> (raw)
In-Reply-To: <CALDnm507QJrWAd76d1LAmW6hstvdBkFwqOaPW1Xj2QKePn-ZeA@mail.gmail.com> ("João Távora"'s message of "Thu, 6 Apr 2023 13:49:42 +0100")
João Távora <joaotavora@gmail.com> writes:
Hi João,
>> I disagree. Running regression tests towards bleeding edge development
>> version of pylsp is not the intention. You cannot expect, that everybody
>> running Emacs tests has installed pylsp like this. But she could have
>> installed the Debian pylsp package.
>
> Sure, or she has a 'pylsp' that prints the complete works of
> Shakespeare. But these tests are designed for the number one
> recommended pylsp installation method. It's AFAIK not the
> "bleeding edge" (which would be a Git installation). And tests
> have been running fine with that installation method for a
> number of months now, maybe even years.
I don't doubt. But you cannot expect that everybody uses "the number one
recommended pylsp installation method".
>> I have used the most recent pylsp package from Debian. If it doesn't
>> cooperate with eglot, we have a problem.
>
> We? I'd say Debian has, right? I don't have anything against it,
> quite the contrary, but I don't have Debian, and I don't program
> against it (that's also a reason why I can't debug this right now).
No, "we" (as the Emacs community) have a problem. Everybody who has
installed the Debian pylsp package, and who runs Emacs' "make check",
will see the errors. And these are not counted as pylsp errors, or
eglot.el errors; they are counted as Emacs errors. We shouldn't show
such a bad performance.
If Debian's pylsp does not cooperate, add a check in eglot-tests.el that
it is skipped.
Testing Debian and/or Emba is pretty easy now. I have just pushed a
patch to master, extending the file admin/notes/emba. There is a new
section "Running Emba tests locally", which you could apply. Use the
build target emcs-eglot instead of emacs-inotify, and run finally "make
-C test eglot-tests", and you'll see what's up.
> I can probably switch to tests to use some other server, maybe
> one whose Debian package is more well-behaved, but this is
> hardly a priority for me.
A priority is that the tests shouldn't fail. That's for all us
developers.
> What/whose problem or scenario are you trying to solve?
> Who is this hypothetical she-user and what is she trying
> to do? Develop Emacs, develop Eglot, run eglot tests, use
> Eglot with python? All/some of the above?
See above. A simple "make check" could already fail, with an improper
pylsp installed.
> What is preventing you or her from installing this external
> tool using its recommended installation method? Does Debian's
> python not carry its 'pip' package manager? Why do you want to
> install it, and why do you want to install it specifically like this?
Again, I'm not speaking about eglot users. They shall know what to
do. But eglot-tests could fail for everybody who has installed a pylsp
package, for example from Debian, w/o even being interested in eglot.
>> I recommend that you investigate why the tests fail. And if this sounds
>> too much, at least the sanity checks shall be improved. (skip-unless
>> (executable-find "pylsp")) doesn't seem to be sufficient then.
>
> I don't have Debian. We can overhaul the sanity checks, but I don't
> immediately see how. Or why. So it's hardly a priority.
See above. With the instructions I have added to admin/notes/emba, it
should be simple.
> João
Best regards, Michael.
next prev parent reply other threads:[~2023-04-06 14:58 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 9:55 bug#62694: 30.0.50; eglot-tests fails with recent pylsp Michael Albinus
2023-04-06 10:54 ` João Távora
2023-04-06 11:22 ` Michael Albinus
2023-04-06 12:49 ` João Távora
2023-04-06 14:58 ` Michael Albinus [this message]
2023-04-06 16:59 ` João Távora
2023-04-06 17:39 ` Michael Albinus
2023-04-06 19:50 ` João Távora
2023-04-07 7:44 ` Michael Albinus
2023-04-07 10:20 ` João Távora
2023-04-07 10:29 ` Michael Albinus
2023-04-07 10:47 ` João Távora
2023-04-07 10:50 ` Michael Albinus
2023-04-07 10:57 ` João Távora
2023-04-07 11:04 ` Gregory Heytings
2023-04-07 11:10 ` João Távora
2023-04-07 11:11 ` Eli Zaretskii
2023-04-07 11:20 ` João Távora
2023-04-07 12:20 ` Michael Albinus
2023-04-07 10:43 ` Eli Zaretskii
2023-04-07 10:51 ` João Távora
2023-04-07 10:53 ` Michael Albinus
2023-04-07 10:59 ` Eli Zaretskii
2023-04-07 11:06 ` João Távora
2023-04-07 11:17 ` Eli Zaretskii
2023-04-07 11:23 ` João Távora
2023-04-07 11:37 ` João Távora
2023-04-07 11:41 ` Michael Albinus
2023-04-07 11:47 ` João Távora
2023-04-07 11:53 ` João Távora
2023-04-07 12:07 ` Eli Zaretskii
2023-04-07 12:13 ` Michael Albinus
2023-04-07 12:22 ` Eli Zaretskii
2023-04-07 12:40 ` João Távora
2023-04-07 12:58 ` Gregory Heytings
2023-04-07 13:02 ` João Távora
2023-04-07 13:57 ` Eli Zaretskii
2023-04-07 12:59 ` Michael Albinus
2023-04-07 13:48 ` Eli Zaretskii
2023-04-07 13:57 ` Michael Albinus
2023-04-07 14:00 ` Eli Zaretskii
2023-04-07 14:04 ` João Távora
2023-04-07 14:33 ` Eli Zaretskii
2023-04-07 15:06 ` Michael Albinus
2023-04-07 19:05 ` João Távora
2023-04-09 13:49 ` Michael Albinus
2023-04-07 12:04 ` Michael Albinus
2023-04-07 12:24 ` João Távora
2023-04-07 12:47 ` Michael Albinus
2023-04-07 13:01 ` João Távora
2023-04-07 13:04 ` Michael Albinus
2023-04-09 11:24 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-09 11:22 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-09 12:41 ` João Távora
2023-04-09 13:21 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-09 14:45 ` João Távora
2023-04-09 15:32 ` Michael Albinus
2023-04-09 15:48 ` João Távora
2023-04-09 16:08 ` Michael Albinus
2023-04-09 18:17 ` João Távora
2023-04-09 19:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ile9t5uj.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=62694@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.