all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: 62694@debbugs.gnu.org, michael.albinus@gmx.de
Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp
Date: Fri, 07 Apr 2023 14:17:49 +0300	[thread overview]
Message-ID: <83wn2ondpe.fsf@gnu.org> (raw)
In-Reply-To: <CALDnm51Qw-K9BtASi78FY=jEQasWPuSAzqbUtd5M=-NAxRGrfQ@mail.gmail.com> (message from João Távora on Fri, 7 Apr 2023 12:06:46 +0100)

> From: João Távora <joaotavora@gmail.com>
> Date: Fri, 7 Apr 2023 12:06:46 +0100
> Cc: michael.albinus@gmx.de, 62694@debbugs.gnu.org
> 
> > The problem does exist, as Micheal has explained in so many words.
> > Please trust him, as I do, that he knows what he is talking about, and
> > would have solved this himself if an easier solution were possible.
> >
> > I see no significant complexity in adding a version test.  We do that
> > in umpteen other places with many other programs.
> 
> It's not a version test. I've already done that for clangd, per Michael's
> request.  Here, pylsp's Debian packaging seems just to be buggy.
> 
> Michael has previously found another buggy way to install clangd for
> example, some method that created a 'clangd' script that didn't
> even respond to `--version`.  Those things are very hard to check against
> and it's just not worth it.

A version test doesn't have to mean literally testing the version.  It
can be a different test, specifically for the problematic behavior.
If we understand the problematic behavior, we can test for it.  (If we
don't understand the problem, how do we know it is in the server and
not in Eglot or elsewhere in Emacs?)

> > > I don't understand what the problem with adding a 'pip install' line
> > > to the EMBA scripts is.
> >
> > Again, please trust Michael on that one.  We will not make any
> > progress if we start second-guessing every request and decision of our
> > peers, especially after you already suggested the upgrade, and Michael
> > already explained why he thought it wasn't the best alternative.
> 
> No he didn't.  He _didn't_ explain what bad thing would come to the
> world if pip install was added to the EMBA scripts.
> 
> Alternatively, simply don't install any pylsp on EMBA.  Boom, also
> problem solved. Eventually, I will rework those tests to not rely on
> pylsp at all, and I'll use something else to test those parts of eglot.el
> 
> But spending time answering these mails doesn't make any progress in
> that direction.

Well, how about coding the test Michael asked, and I seconded, then?
I agree that it will be a much better use of our time than keeping
arguing about it.

TIA





  reply	other threads:[~2023-04-07 11:17 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06  9:55 bug#62694: 30.0.50; eglot-tests fails with recent pylsp Michael Albinus
2023-04-06 10:54 ` João Távora
2023-04-06 11:22   ` Michael Albinus
2023-04-06 12:49     ` João Távora
2023-04-06 14:58       ` Michael Albinus
2023-04-06 16:59         ` João Távora
2023-04-06 17:39           ` Michael Albinus
2023-04-06 19:50             ` João Távora
2023-04-07  7:44               ` Michael Albinus
2023-04-07 10:20                 ` João Távora
2023-04-07 10:29                   ` Michael Albinus
2023-04-07 10:47                     ` João Távora
2023-04-07 10:50                       ` Michael Albinus
2023-04-07 10:57                         ` João Távora
2023-04-07 11:04                           ` Gregory Heytings
2023-04-07 11:10                             ` João Távora
2023-04-07 11:11                           ` Eli Zaretskii
2023-04-07 11:20                             ` João Távora
2023-04-07 12:20                               ` Michael Albinus
2023-04-07 10:43                   ` Eli Zaretskii
2023-04-07 10:51                     ` João Távora
2023-04-07 10:53                       ` Michael Albinus
2023-04-07 10:59                       ` Eli Zaretskii
2023-04-07 11:06                         ` João Távora
2023-04-07 11:17                           ` Eli Zaretskii [this message]
2023-04-07 11:23                             ` João Távora
2023-04-07 11:37                               ` João Távora
2023-04-07 11:41                                 ` Michael Albinus
2023-04-07 11:47                                   ` João Távora
2023-04-07 11:53                                     ` João Távora
2023-04-07 12:07                                 ` Eli Zaretskii
2023-04-07 12:13                                   ` Michael Albinus
2023-04-07 12:22                                     ` Eli Zaretskii
2023-04-07 12:40                                       ` João Távora
2023-04-07 12:58                                         ` Gregory Heytings
2023-04-07 13:02                                           ` João Távora
2023-04-07 13:57                                         ` Eli Zaretskii
2023-04-07 12:59                                       ` Michael Albinus
2023-04-07 13:48                                         ` Eli Zaretskii
2023-04-07 13:57                                           ` Michael Albinus
2023-04-07 14:00                                             ` Eli Zaretskii
2023-04-07 14:04                                               ` João Távora
2023-04-07 14:33                                                 ` Eli Zaretskii
2023-04-07 15:06                                                   ` Michael Albinus
2023-04-07 19:05                                                     ` João Távora
2023-04-09 13:49                                                   ` Michael Albinus
2023-04-07 12:04                             ` Michael Albinus
2023-04-07 12:24                               ` João Távora
2023-04-07 12:47                                 ` Michael Albinus
2023-04-07 13:01                                   ` João Távora
2023-04-07 13:04                                     ` Michael Albinus
2023-04-09 11:24               ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-09 11:22       ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-09 12:41         ` João Távora
2023-04-09 13:21           ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-09 14:45             ` João Távora
2023-04-09 15:32               ` Michael Albinus
2023-04-09 15:48                 ` João Távora
2023-04-09 16:08                   ` Michael Albinus
2023-04-09 18:17                     ` João Távora
2023-04-09 19:04                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wn2ondpe.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=62694@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.