From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp Date: Thu, 06 Apr 2023 16:58:44 +0200 Message-ID: <87ile9t5uj.fsf@gmx.de> References: <87sfddibcn.fsf@gmx.de> <87o7o1tfvc.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23198"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62694@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 06 16:59:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkR5C-0005rW-Ln for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Apr 2023 16:59:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkR4w-0003Ew-JF; Thu, 06 Apr 2023 10:59:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkR4p-0003EL-3x for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 10:59:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkR4o-0006hR-R1 for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 10:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkR4o-0004sT-2n for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 10:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Apr 2023 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62694 X-GNU-PR-Package: emacs Original-Received: via spool by 62694-submit@debbugs.gnu.org id=B62694.168079313518737 (code B ref 62694); Thu, 06 Apr 2023 14:59:02 +0000 Original-Received: (at 62694) by debbugs.gnu.org; 6 Apr 2023 14:58:55 +0000 Original-Received: from localhost ([127.0.0.1]:54699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkR4h-0004s8-9c for submit@debbugs.gnu.org; Thu, 06 Apr 2023 10:58:55 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:53663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkR4e-0004rq-Gl for 62694@debbugs.gnu.org; Thu, 06 Apr 2023 10:58:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1680793125; i=michael.albinus@gmx.de; bh=QYMq2QTLW+R5Hg1NirKdN0N/7xhKNdSDhAFfrUMA4qY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Bk0+ytpe6cLxDyHYvkGZ6uHnvHAK+CVu1NQCiXb8kA1CkERDc/IytEdOfZMAD8HnR IffUF1VFTJdXvaeZ+mmGFqwk/nu7DDaS8artSdt1YrrPv/1e+w54xn8lJb8XsNuxqd y6Y01iTCPuN7LWohqZpwhKMUDdhwNmjk7oAqDuaxV7lA+3Wv1EeWw+MKoGu5ztLS5N NLsEuzuqZb730dOqQPOyL/P1y7gOouelxpoiWw5kqagai+MagaLEs7wnH9HvUEkPxx zQa/3PPprwUnyyDaKxaLw68WUoCgNsEDgbLRB2S5ni86QufWYGmVJZIg8Y9YpI1bnS PopuwAow1B5zg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.0]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M9Fnj-1pnRDO3Typ-006PAn; Thu, 06 Apr 2023 16:58:45 +0200 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 6 Apr 2023 13:49:42 +0100") X-Provags-ID: V03:K1:0ERTa75Aawa9+KNHNi916snEtIyrpVUVigdb+dBSqfDL0rn5krC zl1IMYwcpGLvqGURZCz4EfEZ8EaGMFdI2SpKb0l7SYQPGa4zlEXBjuKBHMndoaGm0jF4XMm hndRFecjMG1wUJ/SZ/UVuI1ewJRsrnrhqHozvz1nSOdAoh9jTVfXUTyqUj1LQ2eKTsOTXSs 39qvJSKgEJaVP44s87Fxw== UI-OutboundReport: notjunk:1;M01:P0:lWNLBEX/akc=;ShVcTgfKBsQWHhoJreq2Nzl44fD U8t1ALRH2KYqzrEDBe/nhV5NFUPAmgbnn0800v/EixK0JERg6AYzrqOlytOHtcQaHssmNWBW/ XdH7QOde2dhuCxFv26XAx2doRzOtRC3w3XMtbUrNOZLMBbQkZu+eWY0CCAPvBgxBLG8YqeisF YYPuoeye8a66+mJ5quxLlHA1lIV0SwsDQ001zF2t3fL5ZUCKYyR2PC/DQBnr/fp+88HMYhJ04 QTSoG3md8jT8gTm3RfBnT1VC8CTQz4Z+wVqsnOz/KAmIorSktMBe5rldXFHha+bGX57+lmYMF /iTGwtYw4T8HuiDkObtFVoNRCWADBmV6AsOWjcJ7tbQjAh+M38k13dMYG6jQV+Mn2TzfHUJAn 8xrPrA0isKj9wL19ZFb/C8K+f9GDv2Yj3nowX3JKTcv7yppcXEWpkz0CxZW/RJlG6XB+ztHi6 VJjL2w8++++4DC4e0Jj2qsIyzDn9kt8Hj8XrHkBu2onol2eDNnpKucMmgR+y8QwYkXAC0zvvy OS9v6ERwlo6XI7oD3lqFib8r0u3oe75H8RY3gzBrG1XHJVybEPib5FD+8XKNm8uMARga7Cqo5 gpD4fKrdLbXDfjNWPQwowqmHAp0gcd8Twc3apM0WvtL2xxUCRc+CVWaMG6Q2JXyYvIYZWCLDk oFU5Ly3oGVACp1QJF4wR2pfHKUJZComVaaSeBNmGzrRDW2bKEi2nkqD20UrzvNLpFm4Q3dmGU nASdMa1thihoVY0kwldHmipMncSPctsFig+UNxsbPydI/mXQPAovpqYmnSBjBZ5+wmRQHlK6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259328 Archived-At: Jo=C3=A3o T=C3=A1vora writes: Hi Jo=C3=A3o, >> I disagree. Running regression tests towards bleeding edge development >> version of pylsp is not the intention. You cannot expect, that everybody >> running Emacs tests has installed pylsp like this. But she could have >> installed the Debian pylsp package. > > Sure, or she has a 'pylsp' that prints the complete works of > Shakespeare. But these tests are designed for the number one > recommended pylsp installation method. It's AFAIK not the > "bleeding edge" (which would be a Git installation). And tests > have been running fine with that installation method for a > number of months now, maybe even years. I don't doubt. But you cannot expect that everybody uses "the number one recommended pylsp installation method". >> I have used the most recent pylsp package from Debian. If it doesn't >> cooperate with eglot, we have a problem. > > We? I'd say Debian has, right? I don't have anything against it, > quite the contrary, but I don't have Debian, and I don't program > against it (that's also a reason why I can't debug this right now). No, "we" (as the Emacs community) have a problem. Everybody who has installed the Debian pylsp package, and who runs Emacs' "make check", will see the errors. And these are not counted as pylsp errors, or eglot.el errors; they are counted as Emacs errors. We shouldn't show such a bad performance. If Debian's pylsp does not cooperate, add a check in eglot-tests.el that it is skipped. Testing Debian and/or Emba is pretty easy now. I have just pushed a patch to master, extending the file admin/notes/emba. There is a new section "Running Emba tests locally", which you could apply. Use the build target emcs-eglot instead of emacs-inotify, and run finally "make -C test eglot-tests", and you'll see what's up. > I can probably switch to tests to use some other server, maybe > one whose Debian package is more well-behaved, but this is > hardly a priority for me. A priority is that the tests shouldn't fail. That's for all us developers. > What/whose problem or scenario are you trying to solve? > Who is this hypothetical she-user and what is she trying > to do? Develop Emacs, develop Eglot, run eglot tests, use > Eglot with python? All/some of the above? See above. A simple "make check" could already fail, with an improper pylsp installed. > What is preventing you or her from installing this external > tool using its recommended installation method? Does Debian's > python not carry its 'pip' package manager? Why do you want to > install it, and why do you want to install it specifically like this? Again, I'm not speaking about eglot users. They shall know what to do. But eglot-tests could fail for everybody who has installed a pylsp package, for example from Debian, w/o even being interested in eglot. >> I recommend that you investigate why the tests fail. And if this sounds >> too much, at least the sanity checks shall be improved. (skip-unless >> (executable-find "pylsp")) doesn't seem to be sufficient then. > > I don't have Debian. We can overhaul the sanity checks, but I don't > immediately see how. Or why. So it's hardly a priority. See above. With the instructions I have added to admin/notes/emba, it should be simple. > Jo=C3=A3o Best regards, Michael.