all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: laszlomail@protonmail.com, Eli Zaretskii <eliz@gnu.org>,
	45333@debbugs.gnu.org
Subject: bug#45333: complex command history should not save optional nil parameters
Date: Tue, 05 Jul 2022 21:43:13 +0200	[thread overview]
Message-ID: <87fsjfs5v2.fsf@web.de> (raw)
In-Reply-To: <87bku3ml4x.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 05 Jul 2022 21:09:50 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> > everything depends on how you define "signature" and where get it from.
> > Does adding an :around advice change the signature of a command?
>
> This isn't a language design issue.  We're talking about making the
> history prettier where it's 100% safe to do so, and nothing more than
> that.

My question is if 100% safe cases exist?  For example:

#+begin_src emacs-lisp
(defun test (&optional x)
  (interactive)
  x)

(advice-add 'test :around (defun test-ad (f &rest args) args))
#+end_src

the signature of `test' is still `(test &optional X)` as reported by C-h
f although the function is able to distinguish a specified nil from a
not specified optional argument.

What you suggest might still be doable by obtaining the effective
signature differently... but I still don't like the idea.

Michael.





  reply	other threads:[~2022-07-05 19:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-20  9:01 bug#45333: complex command history should not save optional nil parameters novim via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-07 11:57 ` Lars Ingebrigtsen
2022-06-07 13:15   ` Eli Zaretskii
2022-06-07 13:20     ` Eli Zaretskii
2022-06-08 11:43     ` Lars Ingebrigtsen
2022-06-08 13:57       ` Eli Zaretskii
2022-06-09 10:22         ` Lars Ingebrigtsen
2022-06-09 10:33           ` Eli Zaretskii
2022-06-10  8:52             ` Lars Ingebrigtsen
2022-07-05 14:16       ` Michael Heerdegen
2022-07-05 14:53         ` Drew Adams
2022-07-05 16:41         ` Lars Ingebrigtsen
2022-07-05 18:45           ` Michael Heerdegen
2022-07-05 18:48             ` Lars Ingebrigtsen
2022-07-05 19:06               ` Michael Heerdegen
2022-07-05 19:09                 ` Lars Ingebrigtsen
2022-07-05 19:43                   ` Michael Heerdegen [this message]
2022-07-05 19:50                     ` Lars Ingebrigtsen
2022-07-05 20:00                       ` Drew Adams
2022-07-05 20:49                       ` Lars Ingebrigtsen
2022-07-05 22:37                         ` Drew Adams
2022-07-06 18:41                         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-07  7:29                           ` Lars Ingebrigtsen
2022-07-07  9:45                             ` Lars Ingebrigtsen
2022-07-07 10:00                             ` Stefan Kangas
2022-07-07 10:06                               ` Lars Ingebrigtsen
2022-07-07 13:54                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-07 14:10                               ` Lars Ingebrigtsen
2022-07-07 14:49                                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-07 14:52                                   ` Lars Ingebrigtsen
2022-07-07 15:05                                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-07 15:21                                       ` Lars Ingebrigtsen
2022-07-07 15:30                                         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-07 18:00                                           ` Lars Ingebrigtsen
2022-07-07 13:58                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-05 20:15               ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsjfs5v2.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=45333@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=laszlomail@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.