From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: New unwind-protect byte-compiler warning Date: Tue, 04 Apr 2023 12:32:37 +0200 Message-ID: <87fs9ghr96.fsf@gmail.com> References: <0106E951-59EB-42C9-8F99-4182F56C6311@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel" , Juri Linkov To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 04 12:33:32 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjdyi-0001ht-Nv for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Apr 2023 12:33:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjdy1-000217-Cs; Tue, 04 Apr 2023 06:32:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjdxz-0001u7-54 for emacs-devel@gnu.org; Tue, 04 Apr 2023 06:32:43 -0400 Original-Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjdxx-00047X-Fx for emacs-devel@gnu.org; Tue, 04 Apr 2023 06:32:42 -0400 Original-Received: by mail-wm1-x333.google.com with SMTP id v20-20020a05600c471400b003ed8826253aso708354wmo.0 for ; Tue, 04 Apr 2023 03:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680604358; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=IVezpH9H+mfQqkDBV+I/xHFoeJBPtWTginXAmOwVdSs=; b=dZPlnaSAI2vKHqISn8mGFiUd0L6X2ygTEiLUVvu7M0yne96q2aXcSnMZ7dDxf5iEx9 hM0Uxavij33jdI4oDta0bs7gaovFWoFDieOka1k0Auc+iQBXMxW1kS5Swqi5Q2e9Dpee TXz/zY+p1pqOcAoRTBgNgi9Ka0rvH28jTUyv8DoW1s3yqLOP/ufBjn7Wc2iqZqThVb+L rsKD+qJvxJDYV4rwliRxwUNn7J2XG7+3+bPPiz86vX+vNO+ki73cozMlH947SSXv6CXm 45EtZAd4zinBnNHBSuuxtBvlp91Euj5Lzbe8qkj5dc/OKNzA2KYFRCWLXdKmT92JgDue Mvmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680604358; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IVezpH9H+mfQqkDBV+I/xHFoeJBPtWTginXAmOwVdSs=; b=pEOdsxKeC9vF3IpecKmyeZdTHiIyWZoIMiLq6EdlMfoqisifogSlX0Qs8k7HyDvhpm DIGMIJ6LItcC2e5oFwW9DiGJXyGBgnmdsUVf3IJxYk6vLm/v46p+PS2nlMqFYJop0Ona cTScx9wmEOJOIK4THexLUdmRCzZ9iVCIGBuhqv1l64TB2icoPQ6aYHGyJnTcmC3KDyk0 vUHC0FKVBnFHq22r1WB/7zTO+F1eGhXukV7rzY+of/OPHZA/tnppjsLxg5qRV4qvNvDV WQLOPNmd72i1Ss4oxg5aVx9EAE3OhcKU3avd9DiEnMYBOX2+uv+CAmx8LAFLDPuNLv/f qdug== X-Gm-Message-State: AAQBX9dMwBm6SeFiigf4ZjciMteiwazVXlhXmQ2XwFS/uW5Wd974OPky HKg9jt7ASserM4e06PRaq14= X-Google-Smtp-Source: AKy350aPR+UIl6UBYa34hBUF4iWJZyHgfnaxAw33hB34dCxG0Q9lEmR50wS/cJzyJO5FelIIZK3W6A== X-Received: by 2002:a1c:ed07:0:b0:3ee:1084:aa79 with SMTP id l7-20020a1ced07000000b003ee1084aa79mr1370186wmh.20.1680604358466; Tue, 04 Apr 2023 03:32:38 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id o5-20020a05600c510500b003ef5bb63f13sm22484140wms.10.2023.04.04.03.32.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 03:32:37 -0700 (PDT) In-Reply-To: <0106E951-59EB-42C9-8F99-4182F56C6311@gmail.com> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Thu, 30 Mar 2023 10:01:42 +0200") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=rpluim@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305097 Archived-At: >>>>> On Thu, 30 Mar 2023 10:01:42 +0200, Mattias Engdeg=C3=A5rd said: Mattias> On master, the byte-compiler now warns about `unwind-protect` = forms lacking actual unwinding code, which is very often a mistake. An Emac= s build currently yields about 30 warnings of this kind. Mattias> I'm mostly going to wait for those with good knowledge about t= he code causing each warning to deal with it. Tell me if I can be of furthe= r help. There's no strong urgency. Mattias> This will eventually leave some warnings claimed by no-one for= me to take on, which will be done in a conservative way, maybe after a wee= k. This one: In mouse-wheel-global-text-scale: mwheel.el:450:6: Warning: =E2=80=98unwind-protect=E2=80=99 without unwi= nd forms is because we=CA=BCre protecting against errors from `global-text-scale-adjust', but unlike `text-scale-{in,de}crease', that doesn=CA=BCt signal an error when you reach the scale limit. Juri, we can add an unwind form of `t', or switch it to `condition-case', whichever you prefer (I=CA=BCm assuming perhaps pessimistically that `global-text-scale-adjust' might signal in future). Robert --=20