From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: New unwind-protect byte-compiler warning Date: Sun, 09 Apr 2023 16:20:54 +0200 Message-ID: <87cz4dxhkp.fsf@gmx.de> References: <0106E951-59EB-42C9-8F99-4182F56C6311@gmail.com> <25A5C1A9-0321-43B6-A359-5659DB79F5F8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8271"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 09 16:22:01 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plVvc-0001x9-PO for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Apr 2023 16:22:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plVui-0007EM-UM; Sun, 09 Apr 2023 10:21:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plVug-0007Do-QQ for emacs-devel@gnu.org; Sun, 09 Apr 2023 10:21:02 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plVuf-0004ai-73 for emacs-devel@gnu.org; Sun, 09 Apr 2023 10:21:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1681050055; i=michael.albinus@gmx.de; bh=GGrv5A4U6V/zQmWPaRmg9hEycntWITcjEw3uUmncYoU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=ODPwzQxYnypJtnLG8KoLOJBSpVxF2hktQIWDVsLq2VfMR28AqWQKvR7u01do5kj6J 72et3t1ge2ODkMX6MXA1liLSDL7JgkvSZZbV3Z9vD8opN9TRVDTLnpOuh3nuBTQC/h 6nWUJ0m7hc23TpLnW+RjdgbEXqDeGGHeJpm/bb6hMv6BeQKRdJewG1SviL1U0dvJ/D 7n1UbtegHK4hP9IhEiuRuBUXXc97yNa2Fo2n0G0DjvjOoUkALswzaT8Bwij2dr93o+ xT4I/aM77i11cnID3hF2U3VJCYJ3RuEpmz6vpSOtUAtPU9k+CN4hlKHczrZ+4OOxkm 1L0/xeDRnpSXQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.0]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MmDIu-1qBoBj0wue-00iAmS; Sun, 09 Apr 2023 16:20:55 +0200 In-Reply-To: <25A5C1A9-0321-43B6-A359-5659DB79F5F8@gmail.com> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Fri, 7 Apr 2023 19:40:03 +0200") X-Provags-ID: V03:K1:8aIMvs5hRWWwZDejtCusQ6rB2c3hCem8VTAayx/14llxzTCyV35 cA6hLbPgdVVy+bKedasCiHHGJkGnTKZBhOJ4jkHPtLigjaTAtCStR/O6z/neGAtkOHbwvBo rmz0andPme9M92/2Q7Q/xWp8/aNZcHbciddDXZ9d1bZ6IpLXIegnx2WVyHlJ8rCZka58OWZ NAkqKkkRC+c9unAJ5WGuQ== UI-OutboundReport: notjunk:1;M01:P0:bbaDHBBUmvw=;x2+rYtG6x5MXQoMrbF/RAf2XFcz KFliEiV2TQbSKYWPvjTi3HviaQdHR9zSr8fXyF2YLN2Ah3dV6fM5nFmWPapzSx093yc8lkjwg zZIXShDan2ZjnflYsjSNM5iVYLjtSQfWqQFEe7gg8RzXwGbsOjTjHah+qo+twhaUCZqqgOPE8 tTFPexINNn+w+j29nLBocsEUJfx11pQ1wqt08yB+5uwf+pgx6HzqfaGHAix6V2QYHX5Yo+/Gm SLdjlZjqotSjqcx5muljkgXMwA+09qHprmicAc0iI1qqXsyYeM2EbifsCP9E03JBDgk7pQTmS Y8Jzq7LKA8vLl+k9h49Zk689KC/CFcG647/d1nIve6yETsxIhFEupxisgtdiKY3yzoFfqXnt9 +zorjj3bFNaHhM4xDTd16g2WxrxMrU6hcYvFZzG/LNVyCTADiQc32Swt/mZp4eEU+zV+jvNbt Scx0I4VfiOGEJRv8AlgVysY1bpyKDuAx+GQX8ETU53xjZRo6/L226l7u3j2Uo+xPPJlP47y5l Fapuigg9tE1QLtQKvL0wHtOmJk5qUj0kCFv3U6xoMKJmnSqwDTswv1sxXaI0vZPr2MI9DyjAb f3P3lgLLsDQKKkLoMKIgaOKIdYP6DAyBM+OP4HTTQLtjKXDktcDKNDC3D52MY/91Te/f0YG74 BZ9XOFMyQm93iY0fIsFz0OlmScpW5fmi2Wkhcu9cw5aKsbDbSa9o+JWvJ7da9+PHW8/ztCbPS Dt+3KET7Fdkx/Rh18l30iMoL/WJ1kfKuOwJa2EPN2qZCehj1SvvuuumfShvklkPQnF4IB54Z Received-SPF: pass client-ip=212.227.17.21; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305206 Archived-At: Mattias Engdeg=C3=A5rd writes: Hi Mattias, > Also thanks to Michael who fixed a few tramp-related warnings. Michael, h= ere's a bonus for you uncovered by an experimental compiler change (that I = didn't end up applying): > >> (defun tramp-sshfs-handle-insert-file-contents >> (filename &optional visit beg end replace) >> "Like `insert-file-contents' for Tramp files." >> (setq filename (expand-file-name filename)) >> (let (signal-hook-function result) >> (unwind-protect >> (setq result >> (insert-file-contents >> (tramp-fuse-local-file-name filename) visit beg end replace)) >> (when visit (setq buffer-file-name filename)) >> (cons filename (cdr result))))) > > The last unwind form seems to expect its value to be used, but it is real= ly discarded. Perhaps it's just a misplaced bracket? Yes, that's an error, uncovered yet. Thanks! I've fixed this in master. Best regards, Michael.