From: Amin Bandali <bandali@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: Eli Zaretskii <eliz@gnu.org>, 57555@debbugs.gnu.org
Subject: bug#57555: 29.0.50; variable-pitch font issue with medium weight default font
Date: Mon, 05 Sep 2022 22:34:02 -0400 [thread overview]
Message-ID: <871qsput7p.fsf@gnu.org> (raw)
In-Reply-To: <0b2303e392485748bca7@heytings.org>
Gregory Heytings writes:
> Amin, can you try the following patch, and tell us if it fixes your
> problem?
>
> diff --git a/src/xfaces.c b/src/xfaces.c
> index 5e3a47d7f8..08f37cf0b2 100644
> --- a/src/xfaces.c
> +++ b/src/xfaces.c
> @@ -6058,7 +6058,7 @@ realize_gui_face (struct face_cache *cache,
> Lisp_Object attrs[LFACE_VECTOR_SIZE]
> }
> if (! FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
> attrs[LFACE_FONT_INDEX]
> - = font_load_for_lface (f, attrs, attrs[LFACE_FONT_INDEX]);
> + = font_load_for_lface (f, attrs, Ffont_spec (0, NULL));
> if (FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
> {
> face->font = XFONT_OBJECT (attrs[LFACE_FONT_INDEX]);
>
Thank you both. Gregory, your proposed patch indeed seems to help fix
this and restore the expected behaviour for my use-case as far as
I can tell; thanks! Would you mind elaborating on how you suspected
this might be a potential fix?
Thanks again,
-a
prev parent reply other threads:[~2022-09-06 2:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 1:35 bug#57555: 29.0.50; variable-pitch font issue with medium weight default font Amin Bandali
2022-09-03 6:23 ` Eli Zaretskii
2022-09-05 7:06 ` Amin Bandali
2022-09-05 11:57 ` Eli Zaretskii
2022-09-05 15:08 ` Amin Bandali
2022-09-05 15:51 ` Eli Zaretskii
2022-09-05 18:19 ` Amin Bandali
2022-09-05 18:43 ` Eli Zaretskii
2022-09-05 21:17 ` Gregory Heytings
2022-09-06 2:28 ` Eli Zaretskii
2022-09-06 8:08 ` Gregory Heytings
2022-09-06 12:50 ` Eli Zaretskii
2022-09-06 13:09 ` Gregory Heytings
2022-09-06 13:15 ` Eli Zaretskii
2022-09-06 14:28 ` Lars Ingebrigtsen
2022-09-06 15:42 ` Eli Zaretskii
2022-09-07 12:44 ` Lars Ingebrigtsen
2022-09-07 13:01 ` Eli Zaretskii
2022-09-08 11:42 ` Lars Ingebrigtsen
2022-09-08 13:34 ` Eli Zaretskii
2022-11-20 13:57 ` Gregory Heytings
2022-11-20 15:27 ` Amin Bandali
2022-11-20 15:46 ` Gregory Heytings
2022-11-20 16:13 ` Amin Bandali
2022-11-20 17:01 ` Gregory Heytings
2022-12-10 22:54 ` Gregory Heytings
2022-09-06 2:34 ` Amin Bandali [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qsput7p.fsf@gnu.org \
--to=bandali@gnu.org \
--cc=57555@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.