all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 57555@debbugs.gnu.org, gregory@heytings.org, bandali@gnu.org
Subject: bug#57555: 29.0.50; variable-pitch font issue with medium weight default font
Date: Tue, 06 Sep 2022 18:42:15 +0300	[thread overview]
Message-ID: <83zgfcik6g.fsf@gnu.org> (raw)
In-Reply-To: <87pmg8r30a.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue,  06 Sep 2022 16:28:21 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Gregory Heytings <gregory@heytings.org>,  bandali@gnu.org,
>   57555@debbugs.gnu.org
> Date: Tue, 06 Sep 2022 16:28:21 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Well, you reverted the important part of commit 6b1ed2f, which Amin
> > said caused his problem.  So you are not on a wrong path wrt that...
> 
> As far as I can tell, your patch just reverted the code back to the
> state before this:
> 
> commit bf0d3f76dcfe7881cb3058169b51cf6602fdcdcb
> Author:     Kenichi Handa <handa@gnu.org>
> AuthorDate: Sun Jul 20 00:18:23 2014 +0900
> 
>     2014-07-19  Kenichi Handa  <handa@gnu.org>
>     
>             * xfaces.c (realize_x_face): Call font_load_for_lface with no
>             mandatory font spec (Bug#17973).
>     
>     2014-07-19  Stefan Monnier  <monnier@iro.umontreal.ca>
>     
>             * font.c (font_score): Return the worst score if the size of
>             ENTITY is wrong by more than a factor 2 (Bug#17973).

Yes.  As I explained back then.

> So we've come full circle.

No, we haven't.  Emacs works as expected: it requests a medium-weight
font for the variable-pitch face, because the fixed-pitch face was
customized to use a medium weight.  Since the font Amin wants to use
for variable-pitch doesn't have a medium variant, Emacs selects
another one.  There's no real problem I see here, except an issue with
user expectations not being satisfied.

"Fixing" this by disregarding all the attributes of the face's font is
throwing the baby with bathwater.





  reply	other threads:[~2022-09-06 15:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-03  1:35 bug#57555: 29.0.50; variable-pitch font issue with medium weight default font Amin Bandali
2022-09-03  6:23 ` Eli Zaretskii
2022-09-05  7:06   ` Amin Bandali
2022-09-05 11:57     ` Eli Zaretskii
2022-09-05 15:08       ` Amin Bandali
2022-09-05 15:51         ` Eli Zaretskii
2022-09-05 18:19           ` Amin Bandali
2022-09-05 18:43             ` Eli Zaretskii
2022-09-05 21:17               ` Gregory Heytings
2022-09-06  2:28                 ` Eli Zaretskii
2022-09-06  8:08                   ` Gregory Heytings
2022-09-06 12:50                     ` Eli Zaretskii
2022-09-06 13:09                       ` Gregory Heytings
2022-09-06 13:15                         ` Eli Zaretskii
2022-09-06 14:28                       ` Lars Ingebrigtsen
2022-09-06 15:42                         ` Eli Zaretskii [this message]
2022-09-07 12:44                           ` Lars Ingebrigtsen
2022-09-07 13:01                             ` Eli Zaretskii
2022-09-08 11:42                               ` Lars Ingebrigtsen
2022-09-08 13:34                                 ` Eli Zaretskii
2022-11-20 13:57                                   ` Gregory Heytings
2022-11-20 15:27                                     ` Amin Bandali
2022-11-20 15:46                                       ` Gregory Heytings
2022-11-20 16:13                                         ` Amin Bandali
2022-11-20 17:01                                           ` Gregory Heytings
2022-12-10 22:54                                             ` Gregory Heytings
2022-09-06  2:34                 ` Amin Bandali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zgfcik6g.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=57555@debbugs.gnu.org \
    --cc=bandali@gnu.org \
    --cc=gregory@heytings.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.