* Re: master f7816c94b6: * lisp/outline.el: Pre-compute some frequent data for button icons
@ 2022-10-23 19:27 Eli Zaretskii
2022-10-23 19:48 ` Juri Linkov
2022-12-12 17:31 ` Juri Linkov
0 siblings, 2 replies; 3+ messages in thread
From: Eli Zaretskii @ 2022-10-23 19:27 UTC (permalink / raw)
To: Juri Linkov; +Cc: emacs-devel
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -1237,7 +1237,7 @@ completions-group-title
> :version "28.1")
>
> (defface completions-group-separator
> - '((t :inherit shadow :strike-through t))
> + '((t :inherit shadow :underline t))
> "Face used for the separator lines between the candidate groups."
> :version "28.1")
Why is this change a good idea? That face was introduced in Emacs 28,
so it's already out in the wild. Why change the default now? If you
personally don't like the looks, you can change it in your
configuration.
And if we _are_ changing the default, the :version tag should be
adjusted.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master f7816c94b6: * lisp/outline.el: Pre-compute some frequent data for button icons
2022-10-23 19:27 master f7816c94b6: * lisp/outline.el: Pre-compute some frequent data for button icons Eli Zaretskii
@ 2022-10-23 19:48 ` Juri Linkov
2022-12-12 17:31 ` Juri Linkov
1 sibling, 0 replies; 3+ messages in thread
From: Juri Linkov @ 2022-10-23 19:48 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
>> (defface completions-group-separator
>> - '((t :inherit shadow :strike-through t))
>> + '((t :inherit shadow :underline t))
>> "Face used for the separator lines between the candidate groups."
>> :version "28.1")
>
> Why is this change a good idea? That face was introduced in Emacs 28,
> so it's already out in the wild. Why change the default now? If you
> personally don't like the looks, you can change it in your
> configuration.
'strike-through' conflicts with outline icons.
Please see the screenshot in bug#57813.
> And if we _are_ changing the default, the :version tag should be
> adjusted.
Ok, will do.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master f7816c94b6: * lisp/outline.el: Pre-compute some frequent data for button icons
2022-10-23 19:27 master f7816c94b6: * lisp/outline.el: Pre-compute some frequent data for button icons Eli Zaretskii
2022-10-23 19:48 ` Juri Linkov
@ 2022-12-12 17:31 ` Juri Linkov
1 sibling, 0 replies; 3+ messages in thread
From: Juri Linkov @ 2022-12-12 17:31 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
>> --- a/lisp/minibuffer.el
>> +++ b/lisp/minibuffer.el
>> @@ -1237,7 +1237,7 @@ completions-group-title
>> :version "28.1")
>>
>> (defface completions-group-separator
>> - '((t :inherit shadow :strike-through t))
>> + '((t :inherit shadow :underline t))
>> "Face used for the separator lines between the candidate groups."
>> :version "28.1")
>
> Why is this change a good idea? That face was introduced in Emacs 28,
> so it's already out in the wild.
Ok, reverted now.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-12 17:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-23 19:27 master f7816c94b6: * lisp/outline.el: Pre-compute some frequent data for button icons Eli Zaretskii
2022-10-23 19:48 ` Juri Linkov
2022-12-12 17:31 ` Juri Linkov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.