all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master f7816c94b6: * lisp/outline.el: Pre-compute some frequent data for button icons
Date: Sun, 23 Oct 2022 22:48:13 +0300	[thread overview]
Message-ID: <86o7u2xqwy.fsf@mail.linkov.net> (raw)
In-Reply-To: <83bkq2qr0p.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 23 Oct 2022 22:27:50 +0300")

>>  (defface completions-group-separator
>> -  '((t :inherit shadow :strike-through t))
>> +  '((t :inherit shadow :underline t))
>>    "Face used for the separator lines between the candidate groups."
>>    :version "28.1")
>
> Why is this change a good idea?  That face was introduced in Emacs 28,
> so it's already out in the wild.  Why change the default now?  If you
> personally don't like the looks, you can change it in your
> configuration.

'strike-through' conflicts with outline icons.
Please see the screenshot in bug#57813.

> And if we _are_ changing the default, the :version tag should be
> adjusted.

Ok, will do.



  reply	other threads:[~2022-10-23 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-23 19:27 master f7816c94b6: * lisp/outline.el: Pre-compute some frequent data for button icons Eli Zaretskii
2022-10-23 19:48 ` Juri Linkov [this message]
2022-12-12 17:31 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86o7u2xqwy.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.