From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master f7816c94b6: * lisp/outline.el: Pre-compute some frequent data for button icons Date: Sun, 23 Oct 2022 22:48:13 +0300 Organization: LINKOV.NET Message-ID: <86o7u2xqwy.fsf@mail.linkov.net> References: <83bkq2qr0p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6403"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 24 05:45:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omoOj-0001Z7-Vb for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Oct 2022 05:45:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omnJG-0005Te-E3; Sun, 23 Oct 2022 22:35:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omgxq-0003ib-28 for emacs-devel@gnu.org; Sun, 23 Oct 2022 15:48:54 -0400 Original-Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omgxo-00035d-0J; Sun, 23 Oct 2022 15:48:53 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 928AFFF803; Sun, 23 Oct 2022 19:48:40 +0000 (UTC) In-Reply-To: <83bkq2qr0p.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 23 Oct 2022 22:27:50 +0300") Received-SPF: pass client-ip=2001:4b98:dc4:8::229; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298298 Archived-At: >> (defface completions-group-separator >> - '((t :inherit shadow :strike-through t)) >> + '((t :inherit shadow :underline t)) >> "Face used for the separator lines between the candidate groups." >> :version "28.1") > > Why is this change a good idea? That face was introduced in Emacs 28, > so it's already out in the wild. Why change the default now? If you > personally don't like the looks, you can change it in your > configuration. 'strike-through' conflicts with outline icons. Please see the screenshot in bug#57813. > And if we _are_ changing the default, the :version tag should be > adjusted. Ok, will do.