Re: discoverability, better defaults and which-key in Emacs

[Eli Zaretskii <eliz@gnu.org>]

> From: Visuwesh <visuweshm@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  justin@burkett.cc,  philipk@posteo.net,
>   luangruo@yahoo.com,  jb@jeremybryant.net,  emacs-devel@gnu.org
> Date: Thu, 08 Feb 2024 07:16:56 +0530
> 
> [புதன் பிப்ரவரி 07, 2024] Dmitry Gutov wrote:
> 
> > [...]
> > diff --git a/src/keyboard.c b/src/keyboard.c
> > index 1f7253a7da1..6d3db5ab615 100644
> > --- a/src/keyboard.c
> > +++ b/src/keyboard.c
> > @@ -589,6 +589,15 @@ echo_dash (void)
> >    AUTO_STRING (dash, "-");
> >    kset_echo_string (current_kboard,
> >  		    concat2 (KVAR (current_kboard, echo_string), dash));
> > +
> > +  if (echo_keystrokes_help)
> > +    {
> > +      AUTO_STRING (help, " (\\`C-h' for help)");
>                                ^^^^^^^
> 
> Shouldn't this part use the value of help-char instead?  (There's also
> the complication with help-form.)

I'm not sure using help-char here is TRT: that character is only in
effect in this situation of it has no binding prefixed by what the
user already typed.  So the effect of changing help-char could be
confusing for newbies, who are the main audience of this feature.  But
I added F1 to that text, which should help if someone did change
help-char.

Thanks.